Skip to content

Commit

Permalink
Don't silently ignore failures in RPM test step in CI
Browse files Browse the repository at this point in the history
Because the RPM test is a separate step, it requires other modules build
in this job to be installed in the local repo, to avoid building most
modules twice. This in turn requires to manually clean them later
to avoid caching them in Github, because only dependencies should be
cached.
  • Loading branch information
nineinchnick authored and findepi committed Sep 23, 2022
1 parent 7b407fc commit 3efa444
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions .github/workflows/ci.yml
Expand Up @@ -61,18 +61,22 @@ jobs:
- name: Maven Checks
run: |
export MAVEN_OPTS="${MAVEN_INSTALL_OPTS}"
$RETRY $MAVEN clean verify -B --strict-checksums -V -T C1 -DskipTests -P ci -pl '!:trino-server-rpm'
$RETRY $MAVEN clean install -B --strict-checksums -V -T C1 -DskipTests -P ci -pl '!:trino-server-rpm'
- name: Test Server RPM
run: |
export MAVEN_OPTS="${MAVEN_INSTALL_OPTS}"
$RETRY bash -c "$MAVEN verify -B --strict-checksums -P ci -pl :trino-server-rpm || find core/trino-server-rpm/ -exec ls -ald {} +"
$RETRY $MAVEN verify -B --strict-checksums -P ci -pl :trino-server-rpm
- name: Clean Maven Output
run: $MAVEN clean -pl '!:trino-server,!:trino-cli'
- uses: docker/setup-qemu-action@v1
with:
platforms: arm64,ppc64le
- name: Test Docker Image
run: core/docker/build.sh
- name: Clean local Maven repo
# Avoid caching artifacts built in this job, cache should only include dependencies
if: steps.cache.outputs.cache-hit != 'true'
run: rm -rf ~/.m2/repository/io/trino/trino-*

check-commits:
runs-on: ubuntu-latest
Expand Down

0 comments on commit 3efa444

Please sign in to comment.