Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix creating empty tables in presto-memory
Previously following scenario would fail: CREATE TABLE memory.default.test (a BIGINT); INSERT INTO memory.default.test SELECT nationkey FROM tpch.tiny.nation; with an error message, that table test was not found on a worker. It is fixed by allowing to "initialize" table on writes (not as it was before only on creates) and by moving sanity checks for detecting worker crashes to asserting expected number of rows per worker.
- Loading branch information
Showing
13 changed files
with
386 additions
and
61 deletions.
There are no files selected for viewing
71 changes: 71 additions & 0 deletions
71
presto-memory/src/main/java/com/facebook/presto/plugin/memory/MemoryDataFragment.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,71 @@ | ||
| /* | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package com.facebook.presto.plugin.memory; | ||
|
|
||
| import com.facebook.presto.spi.HostAddress; | ||
| import com.fasterxml.jackson.annotation.JsonCreator; | ||
| import com.fasterxml.jackson.annotation.JsonProperty; | ||
| import io.airlift.json.JsonCodec; | ||
| import io.airlift.slice.Slice; | ||
| import io.airlift.slice.Slices; | ||
|
|
||
| import static com.google.common.base.Preconditions.checkArgument; | ||
| import static io.airlift.json.JsonCodec.jsonCodec; | ||
| import static java.util.Objects.requireNonNull; | ||
|
|
||
| public class MemoryDataFragment | ||
| { | ||
| private static final JsonCodec<MemoryDataFragment> MEMORY_DATA_FRAGMENT_CODEC = jsonCodec(MemoryDataFragment.class); | ||
|
|
||
| private final HostAddress hostAddress; | ||
| private final long rows; | ||
|
|
||
| @JsonCreator | ||
| public MemoryDataFragment( | ||
| @JsonProperty("hostAddress") HostAddress hostAddress, | ||
| @JsonProperty("rows") long rows) | ||
| { | ||
| this.hostAddress = requireNonNull(hostAddress, "hostAddress is null"); | ||
| checkArgument(rows >= 0, "Rows number can not be negative"); | ||
| this.rows = rows; | ||
| } | ||
|
|
||
| @JsonProperty | ||
| public HostAddress getHostAddress() | ||
| { | ||
| return hostAddress; | ||
| } | ||
|
|
||
| @JsonProperty | ||
| public long getRows() | ||
| { | ||
| return rows; | ||
| } | ||
|
|
||
| public Slice toSlice() | ||
| { | ||
| return Slices.wrappedBuffer(MEMORY_DATA_FRAGMENT_CODEC.toJsonBytes(this)); | ||
| } | ||
|
|
||
| public static MemoryDataFragment fromSlice(Slice fragment) | ||
| { | ||
| return MEMORY_DATA_FRAGMENT_CODEC.fromJson(fragment.getBytes()); | ||
| } | ||
|
|
||
| public static MemoryDataFragment merge(MemoryDataFragment a, MemoryDataFragment b) | ||
| { | ||
| checkArgument(a.getHostAddress().equals(b.getHostAddress()), "Can not merge fragments from different hosts"); | ||
| return new MemoryDataFragment(a.getHostAddress(), a.getRows() + b.getRows()); | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.