-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add test for grant and revoke on table
- Loading branch information
1 parent
4e083b1
commit 652697c
Showing
5 changed files
with
365 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
150 changes: 150 additions & 0 deletions
150
presto-tests/src/test/java/io/prestosql/execution/TestGrantOnTable.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,150 @@ | ||
| /* | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package io.prestosql.execution; | ||
|
|
||
| import com.google.common.collect.ImmutableList; | ||
| import io.prestosql.Session; | ||
| import io.prestosql.connector.Grants; | ||
| import io.prestosql.connector.MockConnectorFactory; | ||
| import io.prestosql.connector.MockConnectorPlugin; | ||
| import io.prestosql.connector.MockConnectorTableHandle; | ||
| import io.prestosql.connector.MutableGrants; | ||
| import io.prestosql.spi.connector.SchemaTableName; | ||
| import io.prestosql.spi.security.Identity; | ||
| import io.prestosql.spi.security.PrestoPrincipal; | ||
| import io.prestosql.spi.security.Privilege; | ||
| import io.prestosql.sql.query.QueryAssertions; | ||
| import io.prestosql.testing.DataProviders; | ||
| import io.prestosql.testing.DistributedQueryRunner; | ||
| import org.testng.annotations.AfterClass; | ||
| import org.testng.annotations.BeforeClass; | ||
| import org.testng.annotations.DataProvider; | ||
| import org.testng.annotations.Test; | ||
|
|
||
| import java.util.EnumSet; | ||
|
|
||
| import static io.prestosql.common.Randoms.randomUsername; | ||
| import static io.prestosql.spi.security.PrincipalType.USER; | ||
| import static io.prestosql.testing.TestingSession.testSessionBuilder; | ||
| import static java.lang.String.format; | ||
| import static org.assertj.core.api.Assertions.assertThat; | ||
| import static org.assertj.core.api.Assertions.assertThatThrownBy; | ||
|
|
||
| public class TestGrantOnTable | ||
| { | ||
| private final SchemaTableName table = new SchemaTableName("default", "table_one"); | ||
| private final Session admin = sessionOf("admin"); | ||
| private final Grants<SchemaTableName> tableGrants = new MutableGrants<>(); | ||
| private DistributedQueryRunner queryRunner; | ||
| private QueryAssertions assertions; | ||
|
|
||
| @BeforeClass | ||
| public void initClass() | ||
| throws Exception | ||
| { | ||
| queryRunner = DistributedQueryRunner.builder(admin).build(); | ||
| MockConnectorFactory connectorFactory = MockConnectorFactory.builder() | ||
| .withListSchemaNames(session -> ImmutableList.of("default")) | ||
| .withListTables((session, schemaName) -> "default".equalsIgnoreCase(schemaName) ? ImmutableList.of(table) : ImmutableList.of()) | ||
| .withGetTableHandle((session, tableName) -> tableName.equals(table) ? new MockConnectorTableHandle(tableName) : null) | ||
| .withSchemaGrants(new MutableGrants<>()) | ||
| .withTableGrants(tableGrants) | ||
| .build(); | ||
| queryRunner.installPlugin(new MockConnectorPlugin(connectorFactory)); | ||
| queryRunner.createCatalog("local", "mock"); | ||
| assertions = new QueryAssertions(queryRunner); | ||
| tableGrants.grant(new PrestoPrincipal(USER, "admin"), table, EnumSet.allOf(Privilege.class), true); | ||
| } | ||
|
|
||
| @AfterClass(alwaysRun = true) | ||
| public void teardown() | ||
| { | ||
| assertions.close(); | ||
| assertions = null; | ||
| } | ||
|
|
||
| @Test(dataProviderClass = DataProviders.class, dataProvider = "trueFalse") | ||
| public void testExistingGrants(boolean grantOption) | ||
| { | ||
| String username = randomUsername(); | ||
| Session user = sessionOf(username); | ||
| tableGrants.grant(new PrestoPrincipal(USER, username), table, EnumSet.allOf(Privilege.class), grantOption); | ||
|
|
||
| assertThat(assertions.query(admin, "SHOW TABLES FROM local.default")).matches("VALUES (VARCHAR 'table_one')"); | ||
| assertThat(assertions.query(user, "SHOW TABLES FROM local.default")).matches("VALUES (VARCHAR 'table_one')"); | ||
| } | ||
|
|
||
| @Test(dataProvider = "privileges") | ||
| public void testValidGrant(String privilege) | ||
| { | ||
| String username = randomUsername(); | ||
| Session user = sessionOf(username); | ||
|
|
||
| queryRunner.execute(admin, format("GRANT %s ON TABLE table_one TO %s", privilege, username)); | ||
|
|
||
| assertThat(assertions.query(user, "SHOW TABLES FROM default")).matches("VALUES (VARCHAR 'table_one')"); | ||
| } | ||
|
|
||
| @Test(dataProvider = "privileges") | ||
| public void testValidGrantWithGrantOption(String privilege) | ||
| { | ||
| String username = randomUsername(); | ||
| Session user = sessionOf(username); | ||
|
|
||
| queryRunner.execute(admin, format("GRANT %s ON TABLE table_one TO %s WITH GRANT OPTION", privilege, username)); | ||
|
|
||
| assertThat(assertions.query(user, "SHOW TABLES FROM default")).matches("VALUES (VARCHAR 'table_one')"); | ||
| assertThat(assertions.query(user, format("GRANT %s ON TABLE table_one TO %s", privilege, randomUsername()))).matches("VALUES (BOOLEAN 'TRUE')"); | ||
| assertThat(assertions.query(user, format("GRANT %s ON TABLE table_one TO %s WITH GRANT OPTION", privilege, randomUsername()))).matches("VALUES (BOOLEAN 'TRUE')"); | ||
| } | ||
|
|
||
| @Test(dataProvider = "privileges") | ||
| public void testGrantOnNonExistingCatalog(String privilege) | ||
| { | ||
| assertThatThrownBy(() -> queryRunner.execute(admin, format("GRANT %s ON TABLE missing_catalog.missing_schema.missing_table TO %s", privilege, randomUsername()))) | ||
| .hasMessageContaining("Table 'missing_catalog.missing_schema.missing_table' does not exist"); | ||
| } | ||
|
|
||
| @Test(dataProvider = "privileges") | ||
| public void testGrantOnNonExistingSchema(String privilege) | ||
| { | ||
| assertThatThrownBy(() -> queryRunner.execute(admin, format("GRANT %s ON TABLE missing_schema.missing_table TO %s", privilege, randomUsername()))) | ||
| .hasMessageContaining("Table 'local.missing_schema.missing_table' does not exist"); | ||
| } | ||
|
|
||
| @Test(dataProvider = "privileges") | ||
| public void testGrantOnNonExistingTable(String privilege) | ||
| { | ||
| assertThatThrownBy(() -> queryRunner.execute(admin, format("GRANT %s ON TABLE default.missing_table TO %s", privilege, randomUsername()))) | ||
| .hasMessageContaining("Table 'local.default.missing_table' does not exist"); | ||
| } | ||
|
|
||
| @DataProvider(name = "privileges") | ||
| public static Object[][] privileges() | ||
| { | ||
| return new Object[][] { | ||
| {"SELECT"}, | ||
| {"ALL PRIVILEGES"} | ||
| }; | ||
| } | ||
|
|
||
| private static Session sessionOf(String username) | ||
| { | ||
| return testSessionBuilder() | ||
| .setIdentity(Identity.ofUser(username)) | ||
| .setCatalog("local") | ||
| .setSchema("default") | ||
| .build(); | ||
| } | ||
| } |
Oops, something went wrong.