Add check for Aggregation's hash symbol in a rule

trinodb · Feb 14, 2020 · 6a29cf9 · 6a29cf9
1 parent 5fc445a
commit 6a29cf9
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/...rc/main/java/io/prestosql/sql/planner/iterative/rule/PushAggregationThroughOuterJoin.java b/...rc/main/java/io/prestosql/sql/planner/iterative/rule/PushAggregationThroughOuterJoin.java
@@ -44,6 +44,7 @@
 import java.util.Optional;
 import java.util.Set;
 
+import static com.google.common.base.Preconditions.checkArgument;
 import static com.google.common.base.Preconditions.checkState;
 import static com.google.common.collect.ImmutableList.toImmutableList;
 import static io.prestosql.SystemSessionProperties.shouldPushAggregationThroughJoin;
@@ -117,6 +118,9 @@ public boolean isEnabled(Session session)
     @Override
     public Result apply(AggregationNode aggregation, Captures captures, Context context)
     {
+        // This rule doesn't deal with AggregationNode's hash symbol. Hash symbols are not yet present at this stage of optimization.
+        checkArgument(!aggregation.getHashSymbol().isPresent(), "unexpected hash symbol");
+
         JoinNode join = captures.get(JOIN);
 
         if (join.getFilter().isPresent()