Implement toString in ExpressionRewriteRuleSet rules

This makes toString reveal the underlying `ExpressionRewriter` implementation (even if it's a lambda). Useful together with the verbose `IterativeOptimizer` timeout reporting, which includes rules' timings.
trinodb · Jan 11, 2022 · 79b61f9 · 79b61f9
1 parent 3f7d9c9
commit 79b61f9
Showing 1 changed file with 37 additions and 0 deletions.
diff --git a/...rino-main/src/main/java/io/trino/sql/planner/iterative/rule/ExpressionRewriteRuleSet.java b/...rino-main/src/main/java/io/trino/sql/planner/iterative/rule/ExpressionRewriteRuleSet.java
@@ -62,6 +62,7 @@
 import static io.trino.sql.planner.plan.Patterns.values;
 import static io.trino.sql.tree.SortItem.Ordering.ASCENDING;
 import static io.trino.sql.tree.SortItem.Ordering.DESCENDING;
+import static java.lang.String.format;
 import static java.util.Objects.requireNonNull;
 
 public class ExpressionRewriteRuleSet
@@ -144,6 +145,12 @@ public Result apply(ProjectNode projectNode, Captures captures, Context context)
             }
             return Result.ofPlanNode(new ProjectNode(projectNode.getId(), projectNode.getSource(), assignments));
         }
+
+        @Override
+        public String toString()
+        {
+            return format("%s(%s)", getClass().getSimpleName(), rewriter);
+        }
     }
 
     private static final class AggregationExpressionRewrite
@@ -214,6 +221,12 @@ public Result apply(AggregationNode aggregationNode, Captures captures, Context
             }
             return Result.empty();
         }
+
+        @Override
+        public String toString()
+        {
+            return format("%s(%s)", getClass().getSimpleName(), rewriter);
+        }
     }
 
     private static final class FilterExpressionRewrite
@@ -241,6 +254,12 @@ public Result apply(FilterNode filterNode, Captures captures, Context context)
             }
             return Result.ofPlanNode(new FilterNode(filterNode.getId(), filterNode.getSource(), rewritten));
         }
+
+        @Override
+        public String toString()
+        {
+            return format("%s(%s)", getClass().getSimpleName(), rewriter);
+        }
     }
 
     private static final class JoinExpressionRewrite
@@ -283,6 +302,12 @@ public Result apply(JoinNode joinNode, Captures captures, Context context)
             }
             return Result.empty();
         }
+
+        @Override
+        public String toString()
+        {
+            return format("%s(%s)", getClass().getSimpleName(), rewriter);
+        }
     }
 
     private static final class ValuesExpressionRewrite
@@ -331,6 +356,12 @@ public Result apply(ValuesNode valuesNode, Captures captures, Context context)
             }
             return Result.empty();
         }
+
+        @Override
+        public String toString()
+        {
+            return format("%s(%s)", getClass().getSimpleName(), rewriter);
+        }
     }
 
     private static final class PatternRecognitionExpressionRewrite
@@ -472,5 +503,11 @@ private Optional<ExpressionAndValuePointers> rewrite(ExpressionAndValuePointers
 
             return Optional.empty();
         }
+
+        @Override
+        public String toString()
+        {
+            return format("%s(%s)", getClass().getSimpleName(), rewriter);
+        }
     }
 }