Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Check whether historyFile is readable/writable
This change updates Console::getHistory() so that if the historyFile is either not readable or writable, then MemoryHistory is used instead of FileHistory. Previously, in that case CLI would crash as FileHistory would fail when flushing the history to disk.
- Loading branch information
1 parent
f2f24cf
commit 92e82dc
Showing
2 changed files
with
49 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
37 changes: 37 additions & 0 deletions
37
presto-cli/src/test/java/com/facebook/presto/cli/TestConsoleHistory.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
/* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
package com.facebook.presto.cli; | ||
|
||
import jline.console.history.FileHistory; | ||
import jline.console.history.MemoryHistory; | ||
import org.testng.annotations.Test; | ||
|
||
import java.io.File; | ||
|
||
import static org.testng.Assert.assertFalse; | ||
import static org.testng.Assert.assertNotNull; | ||
|
||
public class TestConsoleHistory | ||
{ | ||
@Test | ||
public void testNonExistingHomeFolder() throws Exception | ||
{ | ||
File historyFile = new File("/?", ".history"); | ||
assertFalse(historyFile.canRead(), "historyFile is readable"); | ||
assertFalse(historyFile.canWrite(), "historyFile is writable"); | ||
MemoryHistory result = Console.getHistory(historyFile); | ||
assertNotNull(result, "result is null"); | ||
assertFalse(result instanceof FileHistory, "result type is FileHistory"); | ||
} | ||
} |