Skip to content

Commit

Permalink
Remove unsupported types on write path in JDBC connectors
Browse files Browse the repository at this point in the history
These types are not supported in
`com.facebook.presto.plugin.jdbc.JdbcPageSink#appendColumn`, so cannot
be written. Attempt to support these types must be well test-covered on
per-database basis, so they should not be supported in a generic way
anyway.
  • Loading branch information
findepi committed Jan 24, 2019
1 parent 0495b79 commit a13d5d7
Showing 1 changed file with 0 additions and 8 deletions.
Expand Up @@ -61,10 +61,6 @@
import static io.prestosql.spi.type.IntegerType.INTEGER;
import static io.prestosql.spi.type.RealType.REAL;
import static io.prestosql.spi.type.SmallintType.SMALLINT;
import static io.prestosql.spi.type.TimeType.TIME;
import static io.prestosql.spi.type.TimeWithTimeZoneType.TIME_WITH_TIME_ZONE;
import static io.prestosql.spi.type.TimestampType.TIMESTAMP;
import static io.prestosql.spi.type.TimestampWithTimeZoneType.TIMESTAMP_WITH_TIME_ZONE;
import static io.prestosql.spi.type.TinyintType.TINYINT;
import static io.prestosql.spi.type.VarbinaryType.VARBINARY;
import static io.prestosql.spi.type.Varchars.isVarcharType;
Expand All @@ -88,10 +84,6 @@ public class BaseJdbcClient
.put(REAL, "real")
.put(VARBINARY, "varbinary")
.put(DATE, "date")
.put(TIME, "time")
.put(TIME_WITH_TIME_ZONE, "time with timezone")
.put(TIMESTAMP, "timestamp")
.put(TIMESTAMP_WITH_TIME_ZONE, "timestamp with timezone")
.build();

protected final String connectorId;
Expand Down

0 comments on commit a13d5d7

Please sign in to comment.