Skip to content

Commit

Permalink
Remove meaningless test cases
Browse files Browse the repository at this point in the history
The `SortedRangeSet.includesMarker` exists for test only and in actual
code is never invoked with non-exact markers.
  • Loading branch information
findepi committed Jan 11, 2021
1 parent 204d3d5 commit aa06af7
Showing 1 changed file with 0 additions and 10 deletions.
Expand Up @@ -55,9 +55,7 @@ public void testEmptySet()
assertTrue(Iterables.isEmpty(rangeSet.getOrderedRanges()));
assertEquals(rangeSet.getRangeCount(), 0);
assertEquals(rangeSet.complement(), SortedRangeSet.all(BIGINT));
assertFalse(rangeSet.includesMarker(Marker.lowerUnbounded(BIGINT)));
assertFalse(rangeSet.includesMarker(Marker.exactly(BIGINT, 0L)));
assertFalse(rangeSet.includesMarker(Marker.upperUnbounded(BIGINT)));
}

@Test
Expand All @@ -70,9 +68,7 @@ public void testEntireSet()
assertFalse(rangeSet.isSingleValue());
assertEquals(rangeSet.getRangeCount(), 1);
assertEquals(rangeSet.complement(), SortedRangeSet.none(BIGINT));
assertTrue(rangeSet.includesMarker(Marker.lowerUnbounded(BIGINT)));
assertTrue(rangeSet.includesMarker(Marker.exactly(BIGINT, 0L)));
assertTrue(rangeSet.includesMarker(Marker.upperUnbounded(BIGINT)));
}

@Test
Expand All @@ -89,10 +85,8 @@ public void testSingleValue()
assertTrue(Iterables.elementsEqual(rangeSet.getOrderedRanges(), ImmutableList.of(Range.equal(BIGINT, 10L))));
assertEquals(rangeSet.getRangeCount(), 1);
assertEquals(rangeSet.complement(), complement);
assertFalse(rangeSet.includesMarker(Marker.lowerUnbounded(BIGINT)));
assertTrue(rangeSet.includesMarker(Marker.exactly(BIGINT, 10L)));
assertFalse(rangeSet.includesMarker(Marker.exactly(BIGINT, 9L)));
assertFalse(rangeSet.includesMarker(Marker.upperUnbounded(BIGINT)));
}

@Test
Expand Down Expand Up @@ -125,12 +119,10 @@ public void testBoundedSet()
assertEquals(rangeSet, SortedRangeSet.copyOf(BIGINT, normalizedResult));
assertEquals(rangeSet.getRangeCount(), 3);
assertEquals(rangeSet.complement(), complement);
assertFalse(rangeSet.includesMarker(Marker.lowerUnbounded(BIGINT)));
assertTrue(rangeSet.includesMarker(Marker.exactly(BIGINT, 0L)));
assertFalse(rangeSet.includesMarker(Marker.exactly(BIGINT, 1L)));
assertFalse(rangeSet.includesMarker(Marker.exactly(BIGINT, 7L)));
assertTrue(rangeSet.includesMarker(Marker.exactly(BIGINT, 9L)));
assertFalse(rangeSet.includesMarker(Marker.upperUnbounded(BIGINT)));
}

@Test
Expand Down Expand Up @@ -161,11 +153,9 @@ public void testUnboundedSet()
assertEquals(rangeSet, SortedRangeSet.copyOf(BIGINT, normalizedResult));
assertEquals(rangeSet.getRangeCount(), 3);
assertEquals(rangeSet.complement(), complement);
assertTrue(rangeSet.includesMarker(Marker.lowerUnbounded(BIGINT)));
assertTrue(rangeSet.includesMarker(Marker.exactly(BIGINT, 0L)));
assertTrue(rangeSet.includesMarker(Marker.exactly(BIGINT, 4L)));
assertFalse(rangeSet.includesMarker(Marker.exactly(BIGINT, 7L)));
assertTrue(rangeSet.includesMarker(Marker.upperUnbounded(BIGINT)));
}

@Test
Expand Down

0 comments on commit aa06af7

Please sign in to comment.