Update JDBC connectors to reflect SQL DELETE support

trinodb · Jul 23, 2021 · cac8762 · cac8762
1 parent 3c8042b
commit cac8762
Show file tree

Hide file tree

Showing 10 changed files with 26 additions and 9 deletions.
diff --git a/docs/src/main/sphinx/connector/clickhouse.rst b/docs/src/main/sphinx/connector/clickhouse.rst
@@ -135,6 +135,7 @@ Limitations
 
 The following SQL statements aren't  supported:
 
+* :doc:`/sql/delete`
 * :doc:`/sql/grant`
 * :doc:`/sql/revoke`
 * :doc:`/sql/show-grants`

diff --git a/docs/src/main/sphinx/connector/memsql.rst b/docs/src/main/sphinx/connector/memsql.rst
@@ -85,14 +85,15 @@ The connector supports pushdown for a number of operations:
 * :ref:`limit-pushdown`
 * :ref:`topn-pushdown`
 
-Limitations
+SQL support
 -----------
 
 The following SQL statements are not yet supported:
 
-* :doc:`/sql/delete`
 * :doc:`/sql/grant`
 * :doc:`/sql/revoke`
 * :doc:`/sql/show-grants`
 * :doc:`/sql/show-roles`
 * :doc:`/sql/show-role-grants`
+
+.. include:: sql-delete-limitation.fragment
diff --git a/docs/src/main/sphinx/connector/mysql.rst b/docs/src/main/sphinx/connector/mysql.rst
@@ -132,14 +132,15 @@ The connector supports pushdown for a number of operations:
 * :func:`var_pop`
 * :func:`var_samp`
 
-Limitations
+SQL support
 -----------
 
 The following SQL statements are not yet supported:
 
-* :doc:`/sql/delete`
 * :doc:`/sql/grant`
 * :doc:`/sql/revoke`
 * :doc:`/sql/show-grants`
 * :doc:`/sql/show-roles`
 * :doc:`/sql/show-role-grants`
+
+.. include:: sql-delete-limitation.fragment
diff --git a/docs/src/main/sphinx/connector/oracle.rst b/docs/src/main/sphinx/connector/oracle.rst
@@ -368,15 +368,16 @@ The connector supports pushdown for a number of operations:
 * :ref:`limit-pushdown`
 * :ref:`topn-pushdown`
 
-Limitations
+SQL support
 -----------
 
 The following SQL statements are not supported:
 
-* :doc:`/sql/delete`
 * :doc:`/sql/alter-table`
 * :doc:`/sql/grant`
 * :doc:`/sql/revoke`
 * :doc:`/sql/show-grants`
 * :doc:`/sql/show-roles`
 * :doc:`/sql/show-role-grants`
+
+.. include:: sql-delete-limitation.fragment
diff --git a/docs/src/main/sphinx/connector/phoenix.rst b/docs/src/main/sphinx/connector/phoenix.rst
@@ -179,3 +179,7 @@ Property Name               Default Value    Description
 ``bloomfilter``             ``NONE``         Bloomfilter to use. Valid values are ``NONE`` (default), ``ROW``, or ``ROWCOL``.
 =========================== ================ ==============================================================================================================
 
+SQL support
+-----------
+
+.. include:: sql-delete-limitation.fragment
diff --git a/docs/src/main/sphinx/connector/postgresql.rst b/docs/src/main/sphinx/connector/postgresql.rst
@@ -133,6 +133,8 @@ statements, the connector supports the following features:
 * :doc:`/sql/delete`
 * :ref:`sql-schema-table-management`
 
+.. include:: sql-delete-limitation.fragment
+
 .. _postgresql-pushdown:
 
 Pushdown

diff --git a/docs/src/main/sphinx/connector/redshift.rst b/docs/src/main/sphinx/connector/redshift.rst
@@ -77,12 +77,13 @@ Type mapping
 
 .. include:: jdbc-type-mapping.fragment
 
-Limitations
+SQL support
 -----------
 
 The following SQL statements are not yet supported:
 
-* :doc:`/sql/delete`
 * :doc:`/sql/grant`
 * :doc:`/sql/revoke`
 * :doc:`/sql/show-grants`
+
+.. include:: sql-delete-limitation.fragment
diff --git a/docs/src/main/sphinx/connector/sql-delete-limitation.fragment b/docs/src/main/sphinx/connector/sql-delete-limitation.fragment
@@ -0,0 +1,5 @@
+SQL DELETE
+^^^^^^^^^^
+
+If a ``WHERE`` clause is specified, the ``DELETE`` operation only works if the
+predicate in the clause can be fully pushed down to the data source.
diff --git a/docs/src/main/sphinx/connector/sqlserver.rst b/docs/src/main/sphinx/connector/sqlserver.rst
@@ -126,6 +126,7 @@ supports the following features:
 * :doc:`/sql/delete`
 * :ref:`sql-schema-table-management`
 
+.. include:: sql-delete-limitation.fragment
 
 .. _sqlserver-pushdown:
 

diff --git a/docs/src/main/sphinx/sql/delete.rst b/docs/src/main/sphinx/sql/delete.rst
@@ -35,4 +35,4 @@ Limitations
 -----------
 
 Some connectors have limited or no support for ``DELETE``.
-See connector documentation for more details.
+See connector documentation for more details.