Disable preventive GC

trinodb · Dec 15, 2022 · ef53984 · ef53984
1 parent 87f18c7
commit ef53984
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 0 deletions.
diff --git a/core/docker/default/etc/jvm.config b/core/docker/default/etc/jvm.config
@@ -15,3 +15,5 @@
 # Improve AES performance for S3, etc. on ARM64 (JDK-8271567)
 -XX:+UnlockDiagnosticVMOptions
 -XX:+UseAESCTRIntrinsics
+# Disable Preventive GC for performance reasons (JDK-8293861)
+-XX:-G1UsePreventiveGC
diff --git a/core/trino-server-rpm/src/main/resources/dist/config/jvm.config b/core/trino-server-rpm/src/main/resources/dist/config/jvm.config
@@ -14,3 +14,5 @@
 # Improve AES performance for S3, etc. on ARM64 (JDK-8271567)
 -XX:+UnlockDiagnosticVMOptions
 -XX:+UseAESCTRIntrinsics
+# Disable Preventive GC for performance reasons (JDK-8293861)
+-XX:-G1UsePreventiveGC
diff --git a/docs/src/main/sphinx/installation/deployment.rst b/docs/src/main/sphinx/installation/deployment.rst
@@ -143,6 +143,8 @@ The following provides a good starting point for creating ``etc/jvm.config``:
     -Djdk.nio.maxCachedBufferSize=2000000
     -XX:+UnlockDiagnosticVMOptions
     -XX:+UseAESCTRIntrinsics
+    # Disable Preventive GC for performance reasons (JDK-8293861)
+    -XX:-G1UsePreventiveGC
 
 Because an ``OutOfMemoryError`` typically leaves the JVM in an
 inconsistent state, we write a heap dump, for debugging, and forcibly
@@ -156,6 +158,7 @@ temporary directory by adding ``-Djava.io.tmpdir=/path/to/other/tmpdir`` to the
 list of JVM options.
 
 We enable ``-XX:+UnlockDiagnosticVMOptions`` and ``-XX:+UseAESCTRIntrinsics`` to improve AES performance for S3, etc. on ARM64 (`JDK-8271567 <https://bugs.openjdk.java.net/browse/JDK-8271567>`_)
+We disable Preventive GC (``-XX:-G1UsePreventiveGC``) for performance reasons (see `JDK-8293861 <https://bugs.openjdk.org/browse/JDK-8293861>`_)
 
 .. _config_properties: