Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PrestoS3FileSystem#rename does not preserve SSE properties #101

Open
sopel39 opened this issue Jan 29, 2019 · 0 comments
Open

PrestoS3FileSystem#rename does not preserve SSE properties #101

sopel39 opened this issue Jan 29, 2019 · 0 comments

Comments

@sopel39
Copy link
Member

sopel39 commented Jan 29, 2019

Extracted from: prestodb/presto#9916

PrestoS3FileSystem#rename should preserve SSE properties while copying files. Problematic line is: PrestoS3FileSystem.java:407: s3.copyObject. According to S3 Javadoc:

     * By default, all object metadata for the source object except
     * <b>server-side-encryption</b>, <b>storage-class</b> and
     * <b>website-redirect-location</b> are copied to the new destination
     * object, unless new object metadata in the specified
     * {@link CopyObjectRequest} is provided.

On the other hand, maybe PrestoS3FileSystem#rename should throw UnsupportedOperationException? It seems that it shouldn't be used at all because for S3 there should be no temporary objects when inserting into table (see: HiveWriteUtils#isS3FileSystem).
@sopel39 sopel39 assigned Praveen2112 and unassigned Praveen2112 Jan 29, 2019
rice668 pushed a commit to rice668/trino that referenced this issue Jan 31, 2023
[trinodb#101] Update Airlift version to fix log name bug
0b6329e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sopel39 @Praveen2112