Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect date handling in Phoenix 4 & 5 #10749

Merged
merged 1 commit into from
Jan 31, 2022
Merged

Fix incorrect date handling in Phoenix 4 & 5 #10749

merged 1 commit into from
Jan 31, 2022

Conversation

ebyhr
Copy link
Member

@ebyhr ebyhr commented Jan 24, 2022

No description provided.

@cla-bot cla-bot bot added the cla-signed label Jan 24, 2022
@ebyhr ebyhr marked this pull request as draft January 24, 2022 01:53
@ebyhr ebyhr closed this Jan 24, 2022
@ebyhr ebyhr reopened this Jan 24, 2022
@ebyhr
Copy link
Member Author

ebyhr commented Jan 24, 2022 •
edited
Loading

CI

@ebyhr ebyhr marked this pull request as ready for review January 24, 2022 06:15
@ebyhr ebyhr requested a review from hashhar January 27, 2022 14:08
hashhar
hashhar approved these changes Jan 28, 2022
View reviewed changes
Copy link
Member

@hashhar hashhar left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good % question about comment

Also can we mention "negative dates" in PR title and commit to be more specific?

BTW I notice that Phoenix supports larger DATE range than Trino - do we get reasonable error messages when reading those?

plugin/trino-phoenix/src/main/java/io/trino/plugin/phoenix/PhoenixClient.java Outdated Show resolved Hide resolved
@ebyhr
Copy link
Member Author

ebyhr commented Jan 28, 2022 •
edited
Loading

Also can we mention "negative dates" in PR title and commit to be more specific?

The issue isn't specific to negative dates.

BTW I notice that Phoenix supports larger DATE range than Trino - do we get reasonable error messages when reading those?

It throws value exceeded messages.

@ebyhr
Fix incorrect date handling in Phoenix 4 & 5
5440602 
This fixes incorrect results when a value
is older than or equal to 1899-12-31.
@ebyhr ebyhr merged commit e89d5c9 into trinodb:master Jan 31, 2022
@ebyhr ebyhr deleted the ebi/phoenix-date-issue branch January 31, 2022 05:41
@github-actions github-actions bot added this to the 370 milestone Jan 31, 2022
@ebyhr ebyhr mentioned this pull request Jan 31, 2022
Closed
@mosabua mosabua mentioned this pull request Jan 31, 2022
Merged
@ebyhr ebyhr mentioned this pull request Feb 17, 2022
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhofhansl lhofhansl lhofhansl left review comments

@hashhar hashhar hashhar approved these changes

Assignees
No one assigned
Labels
cla-signed
Milestone
370
Development

Successfully merging this pull request may close these issues.
3 participants
@ebyhr @lhofhansl @hashhar