Deprecate passing constraints to getTableStatistics #11877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
reviewed
Apr 11, 2022
| @@ -63,10 +61,7 @@ public TableScanStatsRule(Metadata metadata, StatsNormalizer normalizer) | |||
| return node.getStatistics(); | |||
| } | |||
|
|
|||
| // TODO Construct predicate like AddExchanges's LayoutConstraintEvaluator | |||
There was a problem hiding this comment.
My bad, i forgot about this. applyFilter won't make this obsolete, and this is a good idea.
however, the current state is bad: we pass a Constraint and it's useless. So i think it's better to proceed with this PR, and reintroduce Constraint later, if actually going to be used.
core/trino-spi/src/main/java/io/trino/spi/connector/ConnectorMetadata.java
Show resolved
Hide resolved
plugin/trino-base-jdbc/src/main/java/io/trino/plugin/jdbc/DefaultJdbcMetadata.java
Outdated
Show resolved
Hide resolved
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/IcebergMetadata.java
Outdated
Show resolved
Hide resolved
plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/BaseIcebergConnectorTest.java
Outdated
Show resolved
Hide resolved
nineinchnick
force-pushed
the
get-table-stats-constraints
branch
from
1f01381
to
bc68076
Compare
findepi
reviewed
Apr 13, 2022
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/TableStatisticsMaker.java
Show resolved
Hide resolved
findepi
force-pushed
the
get-table-stats-constraints
branch
from
70ddea7
to
9fcefbf
Compare
|
squashed myself |
findepi
approved these changes
Apr 13, 2022
|
Retriggered CI because #11722 has been merged. |
findepi
added
the
no-release-notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Deprecate passing constraints to
ConnectorMetadata.getTableStatistics(), because it always receivedConstraints.alwaysTrue(). Connectors should handle constraints inapplyFilter(), which prepare the table handle that later will be passed togetTableStatistics().other, mostly refactor but it makes SPI changes
spi
n/a
Related issues, pull requests, and links
Documentation
(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
( ) No release notes entries required.
(x) Release notes entries required with the following suggested text: