Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve some default config values of fault-tolerant execution #12646

Merged
merged 1 commit into from
Jun 9, 2022
Merged

Improve some default config values of fault-tolerant execution #12646

merged 1 commit into from
Jun 9, 2022

Conversation

linzebing
Copy link
Member

@linzebing linzebing commented Jun 2, 2022 •
edited
Loading

Description

Is this change a fix, improvement, new feature, refactoring, or other?

Improvement

Is this a change to the core query engine, a connector, client library, or the SPI interfaces? (be specific)

Configs

How would you describe this change to a non-technical end user or system administrator?

The new values were found better during our testing of batch workloads.

Related issues, pull requests, and links

Documentation

() No documentation is needed.
(x) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.

Release notes

() No release notes entries required.
(x) Release notes entries required with the following suggested text:

# Section
* Improve execution performance by updating default values for configuration options related to task sizing 
when fault-tolerant execution is used (`retry_mode` is set to `TASK`).

@cla-bot cla-bot bot added the cla-signed label Jun 2, 2022
@github-actions github-actions bot added the docs label Jun 2, 2022
losipiuk
losipiuk reviewed Jun 2, 2022
View reviewed changes
core/trino-main/src/main/java/io/trino/memory/MemoryManagerConfig.java
@@ -41,7 +41,7 @@
private DataSize maxQueryMemory = DataSize.of(20, GIGABYTE);
// enforced against user + system memory allocations (default is maxQueryMemory * 2)
private DataSize maxQueryTotalMemory;
private DataSize faultTolerantExecutionTaskMemory = DataSize.of(4, GIGABYTE);
private DataSize faultTolerantExecutionTaskMemory = DataSize.of(5, GIGABYTE);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what a weird base. Maybe 8? ;)

Copy link
Member Author

@linzebing linzebing Jun 2, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I simply copied what @arhimondr set in https://github.com/starburstdata/stargate/pull/2729

losipiuk
losipiuk approved these changes Jun 2, 2022
View reviewed changes
Copy link
Member

@losipiuk losipiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Maybe put sth for the release notes. Maybe sth like:

Improve execution performance by updating default values 
for configuration options related to task sizing 
when fault-tolerant execution is used (`retry_mode` is set to `TASK`).

@arhimondr arhimondr merged commit 99ff1c6 into trinodb:master Jun 9, 2022
@github-actions github-actions bot added this to the 386 milestone Jun 9, 2022
@colebow colebow mentioned this pull request Jun 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@losipiuk losipiuk losipiuk approved these changes

@arhimondr arhimondr arhimondr approved these changes

Assignees
No one assigned
Labels
cla-signed docs
Milestone
386
Development

Successfully merging this pull request may close these issues.
3 participants
@linzebing @losipiuk @arhimondr