Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add trino version to EXPLAIN and EXPLAIN ANALYZE #15317

Merged
merged 1 commit into from
Dec 8, 2022
Merged

Add trino version to EXPLAIN and EXPLAIN ANALYZE #15317

merged 1 commit into from
Dec 8, 2022

Conversation

sopel39
Copy link
Member

@sopel39 sopel39 commented Dec 6, 2022 •
edited
Loading 

General:
* Print Trino version in EXPLAIN and EXPLAIN ANALYZE.

@cla-bot cla-bot bot added the cla-signed label Dec 6, 2022
@sopel39 sopel39 mentioned this pull request Dec 6, 2022
Merged
@github-actions github-actions bot added the docs label Dec 6, 2022
raunaqmorarka
raunaqmorarka reviewed Dec 6, 2022
View reviewed changes
Copy link
Member

@raunaqmorarka raunaqmorarka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're adding it to EXPLAIN, it should go into json plan as well for consistency

@sopel39
Copy link
Member Author

sopel39 commented Dec 7, 2022 •
edited
Loading

Since we're adding it to EXPLAIN, it should go into json plan as well for consistency

I think we could do that as a follow-up, because printing of JSON is a bit more convoluted (e.g. we don't have overall JSON, but we print Map of fragments)

@sopel39 sopel39 merged commit 12b12ed into trinodb:master Dec 8, 2022
@sopel39 sopel39 deleted the ks/explain_trino_version branch December 8, 2022 10:29
@sopel39 sopel39 mentioned this pull request Dec 8, 2022
Closed
@github-actions github-actions bot added this to the 404 milestone Dec 8, 2022
@colebow colebow mentioned this pull request Dec 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raunaqmorarka raunaqmorarka raunaqmorarka approved these changes

@findepi findepi Awaiting requested review from findepi

Assignees
No one assigned
Labels
cla-signed docs
Milestone
405
Development

Successfully merging this pull request may close these issues.
2 participants
@sopel39 @raunaqmorarka