Support insert for Postgres hstore #1894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change allows to insert values of type MAP(VARCHAR, VARCHAR) into a column of type Postgres hstore.
martint
approved these changes
Oct 30, 2019
| @Override | ||
| public TestTable setupTestTable(List<DataTypeTest.Input<?>> inputs) | ||
| { | ||
| TestTable testTable = createTestTable(inputs); |
There was a problem hiding this comment.
You can use try-with-resouces
try (TestTable testTable = createTestTable(inputs)) {
insertRows(testTable, inputs);
return testTable;
}
There was a problem hiding this comment.
I don't think I can do this. testTable must survive beyond this block.
There was a problem hiding this comment.
Oh, that's right. I just saw the close() in the catch block and missed that.
martint
approved these changes
Oct 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows to insert values of type MAP(VARCHAR, VARCHAR)
into a column of type Postgres hstore.
Complementary to #1101