Produce nonshaded trino-jdbc #22098
Produce nonshaded trino-jdbc #22098
Conversation
wendigo
force-pushed
the
serafin/add-non-shaded-jar
branch
from
0f1fdda
to
7dbcde8
Compare
|
This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua |
|
This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua |
|
Also .. should we document this for any reason? And also I assume the default jar is shaded and we dont want to break users and change that.. although arguably the default one should be non-shaded.. |
|
This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua |
|
Closing this pull request, as it has been stale for six weeks. Feel free to re-open at any time. |
Non-shaded version allows usage of classes like InMemoryTrinoResultSet which depend on the trino-client classes which are shaded. This will cause a class mismatch in the runtime (non-shaded class vs shaded-one).
It's useful for testing when one would like to mock ResultSet.
wendigo
force-pushed
the
serafin/add-non-shaded-jar
branch
from
7dbcde8
to
ade8d5c
Compare
mosabua
added
stale-ignore
I think this should absolutely be documented, maybe even with a word for users to know which dependency to use in which context and/or pros/cons of each dependency. |
|
@mosabua we need to follow up documenting this |
|
@gaeljw we will! Thanks for the feedback and sorry for shipping this so late |
|
Thanks a lot folks :) |
Description
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: