Delta lake S3 exclusive write reconciliation #23145
Merged
+370
−229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wendigo
requested review from
electrum and
anusudarsan
and removed request for
electrum
wendigo
force-pushed
the
serafin/s3-exclusive-write
branch
from
e07d221
to
8f47254
Compare
anusudarsan
reviewed
Aug 27, 2024
lib/trino-filesystem-s3/src/test/java/io/trino/filesystem/s3/TestS3FileSystemS3Mock.java
Outdated
Show resolved
Hide resolved
anusudarsan
approved these changes
Aug 27, 2024
wendigo
force-pushed
the
serafin/s3-exclusive-write
branch
from
ac81ecf
to
4570177
Compare
findinpath
reviewed
Aug 27, 2024
lib/trino-filesystem-s3/src/main/java/io/trino/filesystem/s3/S3OutputFile.java
Outdated
Show resolved
Hide resolved
findinpath
reviewed
Aug 27, 2024
lib/trino-filesystem-s3/src/main/java/io/trino/filesystem/s3/S3OutputStream.java
Outdated
Show resolved
Hide resolved
anusudarsan
reviewed
Aug 27, 2024
...java/io/trino/plugin/deltalake/transactionlog/writer/S3NativeTransactionLogSynchronizer.java
Outdated
Show resolved
Hide resolved
lib/trino-filesystem-s3/src/main/java/io/trino/filesystem/s3/S3FileSystemConfig.java
Outdated
Show resolved
Hide resolved
...java/io/trino/plugin/deltalake/transactionlog/writer/S3NativeTransactionLogSynchronizer.java
Outdated
Show resolved
Hide resolved
...java/io/trino/plugin/deltalake/transactionlog/writer/S3NativeTransactionLogSynchronizer.java
Outdated
Show resolved
Hide resolved
...io/trino/plugin/deltalake/TestDeltaLakeMinioWithExclusiveWritesAndHmsConnectorSmokeTest.java
Outdated
Show resolved
Hide resolved
wendigo
changed the title
findinpath
reviewed
Aug 27, 2024
...io/trino/plugin/deltalake/TestDeltaLakeMinioWithExclusiveWritesAndHmsConnectorSmokeTest.java
Outdated
Show resolved
Hide resolved
findinpath
reviewed
Aug 27, 2024
lib/trino-filesystem-s3/src/main/java/io/trino/filesystem/s3/S3FileSystemConfig.java
Outdated
Show resolved
Hide resolved
findinpath
reviewed
Aug 27, 2024
lib/trino-filesystem-s3/src/test/java/io/trino/filesystem/s3/TestS3FileSystemAwsS3.java
Outdated
Show resolved
Hide resolved
|
The PR is quite important for Delta Lake users on top of AWS S3. Pls add a more lengthy description of what it does and add also release notes to it. 🙏 Maybe we should point out that the hypothesis |
wendigo
force-pushed
the
serafin/s3-exclusive-write
branch
from
4570177
to
f730742
Compare
findinpath
reviewed
Aug 27, 2024
.../main/java/io/trino/plugin/deltalake/transactionlog/writer/S3TransactionLogSynchronizer.java
Outdated
Show resolved
Hide resolved
wendigo
force-pushed
the
serafin/s3-exclusive-write
branch
from
f730742
to
36a5c90
Compare
|
@electrum should we enable S3 exclusive write support by default if it's supported by both Minio and AWS? |
wendigo
force-pushed
the
serafin/s3-exclusive-write
branch
from
36a5c90
to
99635c4
Compare
|
Seems to be working :) |
electrum
reviewed
Aug 27, 2024
lib/trino-filesystem-s3/src/main/java/io/trino/filesystem/s3/S3OutputStream.java
Outdated
Show resolved
Hide resolved
lib/trino-filesystem-s3/src/main/java/io/trino/filesystem/s3/S3OutputStream.java
Outdated
Show resolved
Hide resolved
|
|
losipiuk
reviewed
Aug 30, 2024
losipiuk
reviewed
Aug 30, 2024
.../main/java/io/trino/plugin/deltalake/transactionlog/writer/S3TransactionLogSynchronizer.java
Outdated
Show resolved
Hide resolved
wendigo
force-pushed
the
serafin/s3-exclusive-write
branch
2 times, most recently
from
d9d7d3e
to
3ef770b
Compare
|
@losipiuk PTAL |
losipiuk
reviewed
Sep 2, 2024
...in/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/DeltaLakeSynchronizerModule.java
Outdated
Show resolved
Hide resolved
losipiuk
approved these changes
Sep 2, 2024
wendigo
force-pushed
the
serafin/s3-exclusive-write
branch
from
97a0c83
to
faab545
Compare
losipiuk
reviewed
Sep 3, 2024
...in/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/DeltaLakeSynchronizerModule.java
Show resolved
Hide resolved
losipiuk
approved these changes
Sep 3, 2024
findinpath
reviewed
Sep 3, 2024
plugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/DeltaLakeQueryRunner.java
Outdated
Show resolved
Hide resolved
findinpath
reviewed
Sep 3, 2024
...java/io/trino/plugin/deltalake/transactionlog/writer/S3NativeTransactionLogSynchronizer.java
Outdated
Show resolved
Hide resolved
findinpath
reviewed
Sep 3, 2024
.../trino/plugin/deltalake/TestDeltaLakeMinioAndHmsWithoutExclusiveWriteConnectorSmokeTest.java
Outdated
Show resolved
Hide resolved
findinpath
reviewed
Sep 3, 2024
.../trino/plugin/deltalake/TestDeltaLakeMinioAndHmsWithoutExclusiveWriteConnectorSmokeTest.java
Outdated
Show resolved
Hide resolved
findinpath
approved these changes
Sep 3, 2024
anusudarsan
approved these changes
Sep 3, 2024
This allows for the faster, concurrent write reconciliation without the custom locking mechanism that was implemented for S3 when it lacked exclusive write support. Since this is now supported, we should use faster path if possible.
wendigo
force-pushed
the
serafin/s3-exclusive-write
branch
from
faab545
to
a4109bb
Compare
findinpath
reviewed
Sep 4, 2024
...a/io/trino/plugin/deltalake/transactionlog/writer/S3LockBasedTransactionLogSynchronizer.java
Outdated
Show resolved
Hide resolved
findinpath
approved these changes
Sep 4, 2024
|
@findinpath I'll remove TODOs before merging this change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://docs.aws.amazon.com/AmazonS3/latest/userguide/conditional-requests.html#conditional-writes
This allows for the faster, concurrent write reconciliation without the custom locking mechanism
that was implemented for S3 when it lacked exclusive write support. Since this is now supported,
we should use faster path if possible.
Enabled in tests for S3 and Minio tests. Doesn't work in s3mock and
local-stack(support added 29/08/2024).Release notes: Add support for lock-less Delta Lake write reconciliation on S3