s3 select improvements #2399
Merged
s3 select improvements #2399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI failed -- #2348 |
findepi
force-pushed
the
findepi/s3-select-fixes
branch
3 times, most recently
from
d9a444f
to
474042e
Compare
findepi
force-pushed
the
findepi/s3-select-fixes
branch
from
474042e
to
34485dc
Compare
electrum
approved these changes
Jan 9, 2020
|
|
||
| if (TextInputFormat.class.getName().equals(inputFormat)) { | ||
| if (!Objects.equals(schema.getProperty(SKIP_HEADER_COUNT_KEY, "0"), "0")) { | ||
| // S3 Select supports skipping one line of headers, but it was returning incorrect results for presto-hive-hadoop2/conf/files/test_table_with_header.csv.gz |
There was a problem hiding this comment.
Maybe shorten to "for gzip files"
// S3 Select supports skipping one line of headers, but it was returning incorrect results for gzip filesOr just the file name test_table_with_header.csv.gz
There was a problem hiding this comment.
I want to refer to an exact file. I checked that it works correctly some some .gz files, so it looks data-dependent.
I will leave this as-is, and will add a TODO + link to the issue.
There was a problem hiding this comment.
I will leave this as-is,
(primarily because i missed this comment earlier)
findepi
force-pushed
the
findepi/s3-select-fixes
branch
from
34485dc
to
812a87a
Compare
S3 Select does not support skipping footer S3 Select supports skipping one line of header, but it not always was returning correct results.
findepi
force-pushed
the
findepi/s3-select-fixes
branch
2 times, most recently
from
8e67d2e
to
9ca4714
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.