Explicit support for casting from Parquet short decimal to Presto ints #2451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martint
approved these changes
Jan 10, 2020
| @@ -870,6 +873,14 @@ public void testDecimalBackedByINT64() | |||
| } | |||
| } | |||
|
|
|||
| @Test(expectedExceptions = ParquetDecodingException.class, expectedExceptionsMessageRegExp = "Presto decimal column type has different scale \\(2\\) than Parquet decimal column \\(1\\)") | |||
There was a problem hiding this comment.
You can use \\Q ... \\E to avoid having to escape within the literal string you're trying to match.
There was a problem hiding this comment.
i'd recommend org.assertj.core.api.Assertions#assertThatThrownBy instead
sopel39
force-pushed
the
ks/parquet_decimal_casting
branch
from
97de67a
to
3906cd6
Compare
sopel39
force-pushed
the
ks/parquet_decimal_casting
branch
from
3906cd6
to
b35b23f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.