Improve support for floating point types in Domain translator #2582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change, a query like `SELECT col_double FROM t WHERE col_double > 2.0 OR col_double < 5.0` would return NaN values in the result, which is incorrect. That was caused by OR-predicate incorrectly translated to Domain. The union of domains: (col_double > 2.0) and (col_double < 5.0), neither accepting NaN, resulted in domain "not null", accepting NaN. The remaining expression was simplified to TRUE. The issue was fixed by returning the original predicate as the remaining expression.
martint
approved these changes
Jan 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.