-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix multi-join dynamic filtering #2659
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...n/src/main/java/io/prestosql/sql/planner/iterative/rule/RemoveUnsupportedDynamicFilters.java
Outdated
Show resolved
Hide resolved
presto-memory/src/test/java/io/prestosql/plugin/memory/TestMemorySmoke.java
Show resolved
Hide resolved
sopel39
approved these changes
Jan 29, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm % @raunaqmorarka comments
rzeyde-varada
force-pushed
the
fix-multijoin-df
branch
2 times, most recently
from
January 29, 2020 22:09
066ea1f
to
6d4a8f0
Compare
presto-main/src/test/java/io/prestosql/sql/planner/TestDynamicFilter.java
Outdated
Show resolved
Hide resolved
sopel39
reviewed
Jan 30, 2020
...n/src/main/java/io/prestosql/sql/planner/iterative/rule/RemoveUnsupportedDynamicFilters.java
Outdated
Show resolved
Hide resolved
presto-main/src/test/java/io/prestosql/sql/planner/TestDynamicFilter.java
Outdated
Show resolved
Hide resolved
rzeyde-varada
force-pushed
the
fix-multijoin-df
branch
2 times, most recently
from
January 30, 2020 20:19
2d80c7b
to
d58e74a
Compare
rzeyde-varada
force-pushed
the
fix-multijoin-df
branch
from
January 31, 2020 07:56
d58e74a
to
601b069
Compare
Rebased and force-pushed (to re-run which has failed on seemingly unrelated test). |
merged, thanks! |
kewang1024
added a commit
to kewang1024/presto
that referenced
this pull request
Aug 21, 2020
cherry pick from trinodb/trino#2659 Co-Authored-By: Roman Zeyde <zeyde@varada.io>
highker
pushed a commit
to prestodb/presto
that referenced
this pull request
Aug 21, 2020
cherry pick from trinodb/trino#2659 Co-Authored-By: Roman Zeyde <zeyde@varada.io>
shangxinli
pushed a commit
to shangxinli/presto
that referenced
this pull request
Nov 18, 2020
cherry pick from trinodb/trino#2659 Co-Authored-By: Roman Zeyde <zeyde@varada.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that dynamic filters may get "stuck" in join's node filter (when they can't be pushed down to scan nodes), e.g. see "lower" join node in the following plan:
In this case, Presto fails during the execution - since applying dynamic filters is implemented only for ScanFilterAndProject operators (and not LookupJoin operators):
IIUC, the fix may be to ignore dynamic filters that are left at the join nodes - since they should not affect correctness.