Support properties system table in Hive #268
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kokosing
requested changes
Feb 20, 2019
presto-hive/src/main/java/io/prestosql/plugin/hive/HiveConnectorFactory.java
Show resolved
Hide resolved
presto-hive/src/main/java/io/prestosql/plugin/hive/HiveConnectorFactory.java
Show resolved
Hide resolved
presto-hive/src/main/java/io/prestosql/plugin/hive/HiveMetadata.java
Outdated
Show resolved
Hide resolved
presto-hive/src/main/java/io/prestosql/plugin/hive/HiveMetadata.java
Outdated
Show resolved
Hide resolved
presto-hive/src/main/java/io/prestosql/plugin/hive/HiveMetadata.java
Outdated
Show resolved
Hide resolved
presto-hive/src/main/java/io/prestosql/plugin/hive/HiveMetadata.java
Outdated
Show resolved
Hide resolved
presto-hive/src/main/java/io/prestosql/plugin/hive/HiveMetadata.java
Outdated
Show resolved
Hide resolved
presto-hive/src/main/java/io/prestosql/plugin/hive/security/SystemTableAwareAccessControl.java
Outdated
Show resolved
Hide resolved
kokosing
requested changes
Feb 20, 2019
presto-hive/src/main/java/io/prestosql/plugin/hive/security/SystemTableAwareAccessControl.java
Show resolved
Hide resolved
qqibrow
force-pushed
the
show_table_properties
branch
from
aa8993f
to
92f5810
Compare
electrum
approved these changes
Mar 6, 2019
presto-hive/src/test/java/io/prestosql/plugin/hive/TestHiveIntegrationSmokeTest.java
Show resolved
Hide resolved
| "CREATE TABLE test_show_properties" + | ||
| " WITH (" + | ||
| "format = 'orc', " + | ||
| "partitioned_by = ARRAY[ 'SHIP_PRIORITY', 'ORDER_STATUS' ]," + |
There was a problem hiding this comment.
Nit: don't put spaces around array brackets. Also, use lowercase for the column names.
partitioned_by = ARRAY['ship_priority', 'order_status'],
orc_bloom_filter_columns = ARRAY['ship_priority', 'order_status'],| "FROM tpch.tiny.orders"; | ||
|
|
||
| assertUpdate(createTable, "SELECT count(*) FROM orders"); | ||
| BasicQueryInfo createTableQuery = ((DistributedQueryRunner) getQueryRunner()).getCoordinator().getQueryManager().getQueries().stream().filter(basicQueryInfo -> basicQueryInfo.getQuery().equals(createTable)).findFirst().get(); |
There was a problem hiding this comment.
This is a clever way to get the query ID and node version! However, there is a simpler way:
String queryId = (String) computeScalar("SELECT query_id FROM system.runtime.queries WHERE query LIKE 'CREATE TABLE test_show_properties%'");
String nodeVersion = (String) computeScalar("SELECT node_version FROM system.runtime.nodes WHERE coordinator");| assertUpdate(createTable, "SELECT count(*) FROM orders"); | ||
| BasicQueryInfo createTableQuery = ((DistributedQueryRunner) getQueryRunner()).getCoordinator().getQueryManager().getQueries().stream().filter(basicQueryInfo -> basicQueryInfo.getQuery().equals(createTable)).findFirst().get(); | ||
| String nodeVersion = ((DistributedQueryRunner) getQueryRunner()).getCoordinator().refreshNodes().getActiveNodes().stream().map(Node::getVersion).findAny().get(); | ||
| assertQuery("SELECT * FROM \"test_show_properties$properties\"", "SELECT '" + "ship_priority,order_status" + "','" + "0.5" + "','" + createTableQuery.getQueryId().getId() + "','" + nodeVersion + "'"); |
There was a problem hiding this comment.
This is hard to read. Please format like
assertQuery(
"SELECT * FROM \"test_show_properties$properties\"",
format("SELECT 'ship_priority,order_status', 0.5, '%s', '%s', queryId, nodeVersion));
qqibrow
force-pushed
the
show_table_properties
branch
from
92f5810
to
78765e7
Compare
qqibrow
force-pushed
the
show_table_properties
branch
from
78765e7
to
11d1f54
Compare
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support Query syntax
SELECT * FROM "table_name$properties"to return properties defined in hive metastoreRef prestodb/presto#10793
Fixes prestodb/presto#10611