Fix DATA_TYPE, DECIMAL_DIGITS for parametric date/time types #6307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix information reported by `DatabaseMetaData#getColumns`: - fix `DATA_TYPE` for parametric `time` and `time with time zone` - provide `DECIMAL_DIGITS` for parametric `time` and `timestamp` (with and without zone) Test `TYPE_NAME` returned by that method.
|
cc @martint |
losipiuk
reviewed
Dec 11, 2020
presto-jdbc/src/test/java/io/prestosql/jdbc/TestPrestoDatabaseMetaData.java
Show resolved
Hide resolved
losipiuk
reviewed
Dec 11, 2020
losipiuk
approved these changes
Dec 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix information reported by
DatabaseMetaData#getColumns:DATA_TYPEfor parametrictimeandtime with time zoneDECIMAL_DIGITSfor parametrictimeandtimestamp(withand without zone)
Test
TYPE_NAMEreturned by that method.