Fix PagesSpatialIndexFactory reference counting #652
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the change, the reference accounting didn't consider the fact an
operator factory can be duplicated.
For example, after creating a new factory
SpatialJoinOperatorFactory#duplicate
and closing one of the factorieswith
noMoreOperators()
(either the original one or the new one), thePagesSpatialIndexFactory
would be disposed even though there can beSpatialJoinOperator
yet to be created.Inspired by prestodb/presto#12673. A different implementation though.
Fixes prestodb/presto#12672