Fix PagesSpatialIndexFactory reference counting #652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add some details to the "Fix PagesSpatialIndexFactory reference counting" commit explaining how it was broken before? |
findepi
force-pushed
the
spat
branch
2 times, most recently
from
a86031b
to
cc33ee3
Compare
|
@martint added |
Before the change, the reference accounting didn't consider the fact an operator factory can be duplicated. For example, after creating a new factory `SpatialJoinOperatorFactory#duplicate` and closing one of the factories with `noMoreOperators()` (either the original one or the new one), the `PagesSpatialIndexFactory` would be disposed even though there can be `SpatialJoinOperator` yet to be created.
sopel39
approved these changes
Apr 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the change, the reference accounting didn't consider the fact an
operator factory can be duplicated.
For example, after creating a new factory
SpatialJoinOperatorFactory#duplicateand closing one of the factorieswith
noMoreOperators()(either the original one or the new one), thePagesSpatialIndexFactorywould be disposed even though there can beSpatialJoinOperatoryet to be created.Inspired by prestodb/presto#12673. A different implementation though.
Fixes prestodb/presto#12672