Fix information_schema query failures in BigQuery connector #7830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 212e1bb the toRemoteTable method called listTables unconditionally instead of returning early if case-insensitive name matching is not enabled. That caused query failures for information_schema queries because instead of an early return it tried to list tables in a remote schema called `information_schema` (which isn't intended). This change fixes the issue by making the listTables call lazy by using a Supplier instead of a materialized iterable.
losipiuk
approved these changes
May 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 212e1bb the toRemoteTable method
called listTables unconditionally instead of returning early if
case-insensitive name matching is not enabled.
That caused query failures for information_schema queries because
instead of an early return it tried to list tables in a remote schema
called
information_schema(which isn't intended).This change fixes the issue by making the listTables call lazy by using
a Supplier instead of a materialized iterable.