Fix side effect in decimal addition operator #8973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addLongShortLong performs an in-place addition that mutates the value of the Slice associated with "left". This is based on the assumption that "rescale" always returns a new Slice, which would avoid modifications to the input arguments to the operator. However, when the rescale factor is 0, rescale just returns its input argument.
sopel39
approved these changes
Aug 25, 2021
martint
commented
Aug 25, 2021
| Slice value = unscaledDecimal(2); | ||
|
|
||
| addShortLongLong(1, value, 0, false); | ||
| assertThat(value.getBytes()) |
There was a problem hiding this comment.
getBytes() so that the contents of the array are rendered properly in case of an error and the difference is clear.
|
@skrzypo987 do you recall any similar places? |
|
I've looked through my commits regarding 128 ints and it looks like this is the only change like that |
findepi
approved these changes
Aug 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addLongShortLongperforms an in-place addition that mutates the value ofthe Slice associated with
left. This is based on the assumption thatrescalealways returns a new Slice, which would avoid modificationsto the input arguments to the operator. However, when the rescale factor
is 0, rescale just returns its input argument.
Fixes #8968