Disable predicate pushdown for geography, array and struct in BigQuery #9391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ebyhr
commented
Sep 27, 2021
•
ebyhr
commented
- Run all BigQuery tests (Oct 4)
ebyhr
force-pushed
the
ebi/bigquery-disable-pushdown
branch
from
5de6f5f
to
127cab4
Compare
|
CI failure in Phoenix looks #9199 though it's different test method. |
ebyhr
force-pushed
the
ebi/bigquery-disable-pushdown
branch
from
127cab4
to
c06b146
Compare
findepi
reviewed
Sep 30, 2021
plugin/trino-bigquery/src/main/java/io/trino/plugin/bigquery/BigQueryFilterQueryBuilder.java
Show resolved
Hide resolved
ebyhr
force-pushed
the
ebi/bigquery-disable-pushdown
branch
from
c06b146
to
2a63eda
Compare
findepi
approved these changes
Oct 1, 2021
findepi
reviewed
Oct 1, 2021
Comment on lines
315
to
323
| if (this == GEOGRAPHY || type instanceof ArrayType || type instanceof RowType) { | ||
| return Optional.empty(); |
There was a problem hiding this comment.
- what is the enum value for Array and Row. Is it RECORD?
- i would let inidivudla enum option's toStringconverter handle the logic, by returning Optional
There was a problem hiding this comment.
i would let inidivudla enum option's toStringconverter handle the logic, by returning Optional
i pushed a fixup with some proposed changes, but up to you whether you take them or discard
There was a problem hiding this comment.
what is the enum value for Array and Row. Is it RECORD?
Row is RECORD, but field type is used in case of Array. e.g. Array<boolean> -> BOOLEAN.
So, we can't remove the if (type instanceof ArrayType) until fixing it.
ebyhr
force-pushed
the
ebi/bigquery-disable-pushdown
branch
from
6689bd5
to
b752f85
Compare
This was referenced Oct 4, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.