Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Process parameters for CREATE SCHEMA #11485

Merged
merged 1 commit into from Mar 17, 2022
Merged

Process parameters for CREATE SCHEMA #11485

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 10 additions & 0 deletions core/trino-parser/src/main/java/io/trino/sql/tree/DefaultTraversalVisitor.java
View file
Open in desktop
Expand Up @@ -758,6 +758,16 @@ protected Void visitAddColumn(AddColumn node, C context)
return null;
}

@Override
protected Void visitCreateSchema(CreateSchema node, C context)
{
for (Property property : node.getProperties()) {
process(property, context);
}

electrum marked this conversation as resolved.
Show resolved Hide resolved
return null;
}

@Override
protected Void visitCreateTable(CreateTable node, C context)
{
Expand Down
11 changes: 11 additions & 0 deletions testing/trino-tests/src/test/java/io/trino/tests/TestMockConnector.java
View file
Open in desktop
Expand Up @@ -16,6 +16,7 @@
import com.google.common.collect.ImmutableList;
import com.google.common.collect.ImmutableMap;
import com.google.common.collect.ImmutableSet;
import io.trino.Session;
import io.trino.connector.MockConnectorFactory;
import io.trino.connector.MockConnectorPlugin;
import io.trino.connector.MockConnectorTableHandle;
Expand Down Expand Up @@ -210,6 +211,16 @@ public void testSchemaProperties()
.hasMessage("Catalog 'mock' schema property 'unknown_property' does not exist");
}

@Test
public void testExecuteWithSchemaProperties()
{
String query = "CREATE SCHEMA mock.test_schema WITH (boolean_schema_property = ?)";
Session session = Session.builder(getSession())
.addPreparedStatement("my_query", query)
.build();
computeActual(session, "EXECUTE my_query USING true");
}

@Test
public void testTableProperties()
{
Expand Down