Correct DDL to DROP MATERIALIZED VIEW in Iceberg Connector test #11624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o remove the materizlied views in Iceberg connector tests
findepi
reviewed
Mar 23, 2022
| for (MaterializedRow row : baseResult.getMaterializedRows()) { | ||
| assertUpdate("DROP TABLE IF EXISTS " + row.getField(0).toString()); | ||
| assertUpdate("DROP MATERIALIZED VIEW IF EXISTS " + row.getField(0).toString()); |
There was a problem hiding this comment.
The storage table is a table, so the previous code, using DROP TABLE, seemed correct.
However, IMO this cleanup method is not needed at all --- #11626
There was a problem hiding this comment.
@findepi, I can disregard this request in that case.
This review came from the discussion in #11555 (comment), I am fixing the issue #9129 to raise proper exception. Do you mean the DROP TABLE IF EXISTS should exhibit same behavior for materialized views and tables?
cc @findinpath
There was a problem hiding this comment.
"storage table" is a table, not a materialized view
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue: #9129
Related Pull Request: #11555