Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix no push agg to table #12600

Closed
wants to merge 4 commits into from
Closed

Bug fix no push agg to table #12600

wants to merge 4 commits into from

Conversation

Yao-MR-zz
Copy link
Member

Description

Prevent AggregationPushdown for the jdbc connector when the aggrationNode do have the aggration and grouppingset,
in this case the jdbc connect can not applyAggration correctly, and may case wrong sql calculate result in the case, till now, we just prevent it

Related issues, pull requests, and links

issue : #12598

Documentation

( ) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.

Release notes

# Section
* Fix some things. ({}`12598`)

@cla-bot
Copy link

cla-bot bot commented May 31, 2022

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: ywang46.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@cla-bot
Copy link

cla-bot bot commented May 31, 2022

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: ywang46.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@Yao-MR-zz Yao-MR-zz closed this May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants