Change type for CumulativeUserMemory to DataSize to avoid overflows

[garimaj]

Description

Changed type from double to DataSize as for queries with very large memory consumption, double overflows and negative values are rendered.

Is this change a fix, improvement, new feature, refactoring, or other?
Fix

Is this a change to the core query engine, a connector, client library, or the SPI interfaces? (be specific)
Core query engine

How would you describe this change to a non-technical end user or system administrator?
CumulativeUserMemory reports negative values for queries with very large memory consumption, this change fixes that.

Related issues, pull requests, and links

• Fixes Cumulative user memory overflow, visible in the UI #9080

Documentation

(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.

Release notes

( ) No release notes entries required.
( ) Release notes entries required with the following suggested text:

# Section
* Fix some things. ({issue}`9080`)

[cla-bot]

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: garimajain.
This is most likely caused by a git client misconfiguration; please make sure to:

1. check if your git client is configured with an email to sign commits git config --list | grep email
2. If not, set it up using git config --global user.email email@example.com
3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

[cla-bot]

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: garimajain.
This is most likely caused by a git client misconfiguration; please make sure to:

1. check if your git client is configured with an email to sign commits git config --list | grep email
2. If not, set it up using git config --global user.email email@example.com
3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

[findepi]

Changed type from double to DataSize as for queries with very large memory consumption, double overflows and negative values are rendered.

When does double overflow to negative values?

[garimaj]

Changed type from double to DataSize as for queries with very large memory consumption, double overflows and negative values are rendered.

When does double overflow to negative values?

Read more about it, 'double' doesnt oveflow to negative values unless one of the compute params is Negative Infinity.
The types used are long and double which seem sufficient so not sure what could be causing the negative values. Any pointers on how the issue could be repro'ed?

[mosabua]

👋 @garimaj - this PR has become inactive. We hope you are still interested in working on it. Please let us know, and we can try to get reviewers to help with that.

We're working on closing out old and inactive PRs, so if you're too busy or this has too many merge conflicts to be worth picking back up, we'll be making another pass to close it out in a few weeks.