Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update language level to Java 17 #13200

Merged
merged 1 commit into from Aug 3, 2022
Merged

Update language level to Java 17 #13200

merged 1 commit into from Aug 3, 2022

Conversation

martint
Copy link
Member

@martint martint commented Jul 16, 2022 •
edited

Documentation

(x) Sufficient documentation is included in this PR.

Release notes

(x) No release notes entries required.

Fixes #9876 (completes)

@cla-bot cla-bot bot added the cla-signed label Jul 16, 2022
@martint martint force-pushed the java17 branch 2 times, most recently from 0cbccb6 to c24399d Compare July 16, 2022 00:58
@wendigo
Copy link
Contributor

wendigo commented Jul 16, 2022

That was easy!

@sajjoseph
Copy link
Contributor

While trying out JDK 17 with the latest version of Trino (390), we noticed the following. Just thought of sharing in case others come across similar challenges.

  1. Hive catalogs with Kerberos authentication were found to be not using the strong encryption and so we had to add the following flag in krb5.conf file to allow the old configuration to work.
    allow_weak_crypto = true
    (More details - https://stackoverflow.com/questions/70774313/jdk-17-java-17-kerberos-authentication-fail)

  2. Our custom Ranger plugin was using nashorn javascript engine for policy evaluation and this javascript engine is deprecated in JDK 17. We are trying out graalvm.

findepi
findepi approved these changes Jul 19, 2022
View reviewed changes
.github/workflows/docs.yml Outdated Show resolved Hide resolved
@martint martint marked this pull request as ready for review July 19, 2022 21:13
@findepi findepi mentioned this pull request Jul 20, 2022
Closed
8 tasks
electrum
electrum reviewed Jul 29, 2022
View reviewed changes
pom.xml Outdated Show resolved Hide resolved
@martint martint merged commit 4473226 into trinodb:master Aug 3, 2022
@findepi findepi mentioned this pull request Aug 3, 2022
Merged
@github-actions github-actions bot added this to the 393 milestone Aug 3, 2022
@colebow colebow mentioned this pull request Aug 5, 2022
Merged
@tangjiangling tangjiangling mentioned this pull request Aug 18, 2022
Merged
@martint martint deleted the java17 branch August 26, 2022 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@findepi findepi findepi approved these changes

@electrum electrum electrum approved these changes

Assignees
No one assigned
Labels
cla-signed
Milestone
393
Development

Successfully merging this pull request may close these issues.

Update to Java 17
5 participants
@martint @wendigo @sajjoseph @electrum @findepi