Use file metastore in TestDeltaLakeAnalyze #13684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findinpath
approved these changes
Aug 16, 2022
| HiveMinioDataLake hiveMinioDataLake = closeAfterClass(new HiveMinioDataLake(bucketName)); | ||
| hiveMinioDataLake.start(); | ||
| return DeltaLakeQueryRunner.createS3DeltaLakeQueryRunner( | ||
| return DeltaLakeQueryRunner.createDeltaLakeQueryRunner( |
homar
approved these changes
Aug 16, 2022
To avoid flaky failure from Thrift Hive metastore. BaseDeltaLakeConnectorSmokeTest covers S3 (MinIO) and ABFS , so changing to local file system should be fine.
ebyhr
force-pushed
the
ebi/delta-analyze-test
branch
from
0c64fd5
to
a38688b
Compare
hashhar
approved these changes
Aug 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use file metastore in TestDeltaLakeAnalyze to avoid flaky tests.
Example failure: https://github.com/trinodb/trino/runs/7832847770
Documentation
(x) No documentation is needed.
Release notes
(x) No release notes entries required.