Add Pseudo-column for fileSize and fileModifiedTime #1428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Praveen2112
force-pushed
the
hive_hidden_columns
branch
from
7f844d0
to
e137f19
Compare
kokosing
approved these changes
Sep 3, 2019
| @@ -45,6 +45,11 @@ | |||
| public static final HiveType BUCKET_HIVE_TYPE = HIVE_INT; | |||
There was a problem hiding this comment.
WRT to commit message:
Add Hive Connector $file_size hidden column
There was a problem hiding this comment.
bump, for this commit and others
presto-hive/src/test/java/io/prestosql/plugin/hive/TestHiveIntegrationSmokeTest.java
Outdated
Show resolved
Hide resolved
presto-hive/src/test/java/io/prestosql/plugin/hive/TestHiveIntegrationSmokeTest.java
Outdated
Show resolved
Hide resolved
presto-hive/src/main/java/io/prestosql/plugin/hive/HiveColumnHandle.java
Show resolved
Hide resolved
presto-hive/src/test/java/io/prestosql/plugin/hive/TestHiveIntegrationSmokeTest.java
Outdated
Show resolved
Hide resolved
presto-hive/src/test/java/io/prestosql/plugin/hive/TestHiveIntegrationSmokeTest.java
Outdated
Show resolved
Hide resolved
Praveen2112
force-pushed
the
hive_hidden_columns
branch
from
e137f19
to
558af9b
Compare
|
@kokosing Thanks for your insights. Have applied your comments. |
kokosing
approved these changes
Sep 4, 2019
presto-hive/src/test/java/io/prestosql/plugin/hive/TestHiveIntegrationSmokeTest.java
Show resolved
Hide resolved
presto-hive/src/test/java/io/prestosql/plugin/hive/TestHiveIntegrationSmokeTest.java
Show resolved
Hide resolved
Praveen2112
force-pushed
the
hive_hidden_columns
branch
3 times, most recently
from
d585b36
to
71aaf3c
Compare
Praveen2112
force-pushed
the
hive_hidden_columns
branch
3 times, most recently
from
d7b6c9a
to
604c512
Compare
kokosing
reviewed
Sep 11, 2019
| { | ||
| long testStartTime = Instant.now().toEpochMilli(); | ||
|
|
||
| Thread.sleep(2_000); |
There was a problem hiding this comment.
instead of sleep here you could use testStartTime - 2000
Praveen2112
force-pushed
the
hive_hidden_columns
branch
2 times, most recently
from
4600615
to
c40007c
Compare
Praveen2112
force-pushed
the
hive_hidden_columns
branch
from
c40007c
to
612c266
Compare
|
Merged, thanks! |
findepi
reviewed
Apr 8, 2021
|
|
||
| TableMetadata tableMetadata = getTableMetadata(catalog, TPCH_SCHEMA, "test_file_modified_time"); | ||
|
|
||
| List<String> columnNames = ImmutableList.of("col0", "col1", PATH_COLUMN_NAME, FILE_SIZE_COLUMN_NAME, FILE_MODIFIED_TIME_COLUMN_NAME); |
There was a problem hiding this comment.
Consider changing test method name to cover more than just "FileModifiedTimeHiddenColumn"
agrawalreetika
added a commit
to agrawalreetika/prestodb
that referenced
this pull request
Aug 1, 2021
Cherry pick of trinodb/trino#1428 Co-authored-by: Praveen2112 <praveenkrishna2112@outlook.com>
pettyjamesm
pushed a commit
to prestodb/presto
that referenced
this pull request
Aug 17, 2021
Cherry pick of trinodb/trino#1428 Co-authored-by: Praveen2112 <praveenkrishna2112@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1423. Added two hidden columns for Hive and Iceberg connector.