Drop orphaned test Glue databases left behind by Delta Lake Databricks product tests #15031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krvikash
reviewed
Nov 15, 2022
.../main/java/io/trino/tests/product/deltalake/TestDeltaLakeDatabricksCleanUpGlueMetastore.java
Outdated
Show resolved
Hide resolved
.../main/java/io/trino/tests/product/deltalake/TestDeltaLakeDatabricksCleanUpGlueMetastore.java
Outdated
Show resolved
Hide resolved
findinpath
force-pushed
the
delta-databricks-cleanup-glue-metastore
branch
from
3da0d3b
to
83b4754
Compare
ebyhr
approved these changes
Nov 16, 2022
.../main/java/io/trino/tests/product/deltalake/TestDeltaLakeDatabricksCleanUpGlueMetastore.java
Outdated
Show resolved
Hide resolved
krvikash
approved these changes
Nov 16, 2022
findinpath
force-pushed
the
delta-databricks-cleanup-glue-metastore
branch
from
83b4754
to
eb2c000
Compare
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use a rather generic way to cleanup the orphaned test AWS Glue databases.
Under the assumption that the cleanup from delta lake integration tests and product tests is done on different AWS accounts, the algorithm duplicates
https://github.com/trinodb/trino/blob/b9585639513626c84caeffcf2ba559e20631d00e/plugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/metastore/glue/TestDeltaLakeCleanUpGlueMetastore.java
In case the above assumption is false (see #15011) , we should better remove altogether this test.
Non-technical explanation
Test infrastructure change
Release notes
(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: