Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bad parameter count in code generator when column uses double slots #15979

Merged
merged 2 commits into from Mar 27, 2023
Merged

Fix bad parameter count in code generator when column uses double slots #15979

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4f25f6b
Fix bad parameter count in code generator when column uses double slots
zhaner08 Feb 5, 2023
b08a3cc
Update the limit to 64 from 84 to address the comment
zhaner08 Mar 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/trino-main/src/main/java/io/trino/sql/gen/BytecodeUtils.java
View file
Open in desktop
Expand Up @@ -354,7 +354,7 @@ else if (type == ConnectorSession.class) {
private static InvocationArgumentConvention getPreferredArgumentConvention(BytecodeNode argument, int argumentCount, boolean nullable)
{
// a Java function can only have 255 arguments, so if the count is low use block position or boxed nullable as they are more efficient
if (argumentCount <= 100) {
if (argumentCount <= 64) {
if (argument instanceof InputReferenceNode) {
return BLOCK_POSITION;
}
Expand Down