Fix compatibility issue on COLLECTION_DELIM in Hive 3.x for text file #1733
Conversation
…nts#COLLECTION_DELIM, but also introduced a breaking change. trinodb#1321 fixed this compatibility issue for RC files, while leaving TEXT files out.
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to cla@prestosql.io. For more information, see https://github.com/prestosql/cla. |
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to cla@prestosql.io. For more information, see https://github.com/prestosql/cla. |
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to cla@prestosql.io. For more information, see https://github.com/prestosql/cla. |
|
hi, Thanks for raising this PR. I guess we can squash all the commits into a single one. And for a git commit message we follow these guidelines. The commit message can be like |
presto-hive/src/main/java/io/prestosql/plugin/hive/util/HiveUtil.java
Outdated
Show resolved
Hide resolved
findepi
changed the title
|
@Anurag870 please make sure to fill the CLA. |
|
CLA sent @findepi |
Co-Authored-By: Piotr Findeisen <piotr.findeisen@gmail.com>
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to cla@prestosql.io. For more information, see https://github.com/prestosql/cla. |
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
|
@Anurag870 You can squash all the commits into a single one. |
|
Also, let's update commit message like |
|
Merged as c774294, thanks! (i squashed the commits) |
Fixes #1714
HIVE-16922 fixed the typo of org.apache.hadoop.hive.serde.serdeConstants#COLLECTION_DELIM, but also introduced a breaking change.
#1321 fixed this compatibility issue for RC files while leaving TEXT files out.