Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update error-prone to 2.20.0 #17941

Merged
merged 1 commit into from
Jun 19, 2023
Merged

Conversation

wendigo
Copy link
Contributor

@wendigo wendigo commented Jun 16, 2023

This is the first version supporting JDK 21

Description

Additional context and related issues

Release notes

( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent.

@wendigo
Copy link
Contributor Author

wendigo commented Jun 16, 2023

Locally it passed all the existing checks so there are no regressions.

@mosabua
Copy link
Member

mosabua commented Jun 16, 2023

I will merge after CI passes, if desired

@wendigo
Copy link
Contributor Author

wendigo commented Jun 16, 2023

Please do @mosabua

@wendigo
Copy link
Contributor Author

wendigo commented Jun 16, 2023

@mosabua error-prone passed 🎉

@mosabua
Copy link
Member

mosabua commented Jun 16, 2023

This looks okay to me. Can you confirm that the failure is unrelated @wendigo @martint ?

@wendigo
Copy link
Contributor Author

wendigo commented Jun 17, 2023

It is unrelated @mosabua

This is the first version supporting JDK 21
@mosabua mosabua merged commit 5d14d6f into trinodb:master Jun 19, 2023
84 of 85 checks passed
@github-actions github-actions bot added this to the 420 milestone Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants