Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DevelopmentServer cannot be launched #18773

Merged
merged 1 commit into from Aug 22, 2023

Conversation

takezoe
Copy link
Member

@takezoe takezoe commented Aug 22, 2023

Description

After #18623, DevelopmentServer fails to launch with the following error:

com.google.inject.CreationException: Unable to create injector, see the following errors:

1) [Guice/ErrorInjectingConstructor]: NoClassDefFoundError: org/codehaus/plexus/util/xml/XmlStreamReader
  at DevelopmentPluginsProvider.<init>(DevelopmentPluginsProvider.java:50)
  while locating DevelopmentPluginsProvider
  at DevelopmentServer.lambda$getAdditionalModules$0(DevelopmentServer.java:33)
  while locating PluginManager$PluginsProvider annotated with @RealOptionalBinder$Actual
  at PluginManager.<init>(PluginManager.java:114)
      \_ for 1st parameter pluginsProvider
  while locating PluginManager
  at ServerMainModule.setup(ServerMainModule.java:457)
  while locating PluginInstaller annotated with @RealOptionalBinder$Default

...

Adding a runtime dependency on plexus-xml to trino-server-dev solves the issue.

Additional context and related issues

#18623

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.

@cla-bot cla-bot bot added the cla-signed label Aug 22, 2023
<groupId>org.codehaus.plexus</groupId>
<artifactId>plexus-xml</artifactId>
<scope>runtime</scope>
</dependency>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ref:

<!-- TODO: move it to airlift -->
<dependency>
<groupId>org.codehaus.plexus</groupId>
<artifactId>plexus-xml</artifactId>
<scope>runtime</scope>
</dependency>

@ebyhr ebyhr merged commit e91aebf into trinodb:master Aug 22, 2023
41 checks passed
@github-actions github-actions bot added this to the 425 milestone Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants