Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow writing to externally provided JDK #18797

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

wendigo
Copy link
Contributor

@wendigo wendigo commented Aug 24, 2023

Some product test environments can import certificates to cacerts, which will fail if the externally provided JDK is mounted read-only.

Description

Additional context and related issues

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

Some product test environments can import certificates to cacerts,
which will fail if the externally provided JDK is mounted read-only.
@wendigo
Copy link
Contributor Author

wendigo commented Aug 24, 2023

I've verified locally that the custom JDK is mounted read-writeable:

        "Mounts": [
            {
                "Type": "bind",
                "Source": "/Users/mateuszgajewski/Projects/src/github.com/trinodb/trino/core/trino-server/target/trino-server-425-SNAPSHOT.tar.gz",
                "Destination": "/docker/presto-server.tar.gz",
                "Mode": "ro",
                "RW": false,
                "Propagation": "rprivate"
            },
            {
                "Type": "bind",
                "Source": "/var/folders/n4/vl45d5rn5n1_yk_pl5xkpd380000gn/T/ptl-tmp-download/zulu21-ea-arm64/zulu21.0.57-ea-jdk21.0.0-ea.22-linux_aarch64",
                "Destination": "/usr/lib/jvm/zulu21-ea",
                "Mode": "rw",
                "RW": true,
                "Propagation": "rprivate"
            }
        ],

@wendigo wendigo merged commit f946757 into trinodb:master Aug 24, 2023
41 checks passed
@wendigo wendigo deleted the serafin/jdk-provider-mount branch August 24, 2023 15:44
@github-actions github-actions bot added this to the 425 milestone Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants