Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Error Prone to 2.22.0 #19129

Merged
merged 1 commit into from Sep 22, 2023
Merged

Conversation

ksobolew
Copy link
Contributor

Description

We can finally remove the suppressions on records for UnusedVariable.

Additional context and related issues

Finally fixes google/error-prone#2713

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

We can finally remove the suppressions on `record`s for
`UnusedVariable`.
@wendigo
Copy link
Contributor

wendigo commented Sep 22, 2023

@ksobolew this time for real? :P

@wendigo wendigo merged commit 726a6ed into trinodb:master Sep 22, 2023
88 checks passed
@wendigo
Copy link
Contributor

wendigo commented Sep 22, 2023

Thanks @ksobolew 🎉

@github-actions github-actions bot added this to the 427 milestone Sep 22, 2023
@ksobolew ksobolew deleted the kudi/error-prone-222 branch September 25, 2023 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

UnusedVariable sometimes gives false positives for record parameters
2 participants