Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quote row type field names #1963

Merged
merged 5 commits into from Nov 8, 2019
Merged

Quote row type field names #1963

merged 5 commits into from Nov 8, 2019

Commits on Nov 8, 2019

  1. Use getDisplayName instead of TypeSignature in error message

    @martint
    martint committed Nov 8, 2019
    Configuration menu
    Copy the full SHA
    91d74c8 View commit details
    Browse the repository at this point in the history

  2. Quote identifier name during row subscript desugar 

    Names can be reserved SQL keywords, so we need to quote them
to avoid issues when deserializing plans on workers.
    @martint
    martint committed Nov 8, 2019
    Configuration menu
    Copy the full SHA
    e566da2 View commit details
    Browse the repository at this point in the history

  3. Use display name for Type's toString

    @martint
    martint committed Nov 8, 2019
    Configuration menu
    Copy the full SHA
    e65e10a View commit details
    Browse the repository at this point in the history

  4. Remove use of TypeSignature from OperatorNotFoundException

    @martint
    martint committed Nov 8, 2019
    Configuration menu
    Copy the full SHA
    da2f1ff View commit details
    Browse the repository at this point in the history

  5. Quote field names in TypeSignature 

    TypeSignature is used for encoding the identity of a type, which
is then parsed (for now) using the SQL parser. Since some fields
names might collide with SQL reserved words, we need to quote them.
    @martint
    martint committed Nov 8, 2019
    Configuration menu
    Copy the full SHA
    9adf159 View commit details
    Browse the repository at this point in the history