-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update TableFunctionProcessorProvider.getDataProcessor to include ConnectorSession parameter #19779
Conversation
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
@findepi Not all too familiar with that |
Ah, nevermind. I just saw b060fff. Let me know if there is anything else I need to do. |
can you please make sure you filled the CLA? For more information, see https://github.com/trinodb/cla. |
Already signed and sent a week ago. |
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
Thanks! Let's wait until it's processed by @martint . |
…nectorSession parameter
f74f6df
to
49f56b5
Compare
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
Rebased and also added |
CLA processed. Thanks @martint! |
@cla-bot check |
The cla-bot has been summoned, and re-checked this pull request! |
import java.util.List; | ||
import java.util.Optional; | ||
|
||
public class ClassLoaderSafeTableFunctionDataProcessor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @homar
Description
Fixes #19778
Update
TableFunctionProcessorProvider.getDataProcessor
to includeConnectorSession
parameter to provide a consistent interface withTableFunctionProcessorProvider.getSplitProcessor
.Additional context and related issues
Slack discussion
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text: