Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TableFunctionProcessorProvider.getDataProcessor to include ConnectorSession parameter #19779

Merged
merged 1 commit into from
Nov 23, 2023

Conversation

tbaeg
Copy link
Member

@tbaeg tbaeg commented Nov 16, 2023

Description

Fixes #19778

Update TableFunctionProcessorProvider.getDataProcessor to include ConnectorSession parameter to provide a consistent interface with TableFunctionProcessorProvider.getSplitProcessor.

Additional context and related issues

Slack discussion

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text:

# Section
* Update `TableFunctionProcessorProvider.getDataProcessor` to include `ConnectorSession` parameter. This is a breaking change to the interface. ({issue}`19778`)

Copy link

cla-bot bot commented Nov 16, 2023

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@tbaeg
Copy link
Member Author

tbaeg commented Nov 21, 2023

@findepi Not all too familiar with that trino-sqlserver error and didn't seem related to the changes I made at first glad. Any chance you or someone more close to the plugin would be able to assist?

@tbaeg
Copy link
Member Author

tbaeg commented Nov 21, 2023

Ah, nevermind. I just saw b060fff. Let me know if there is anything else I need to do.

@findepi
Copy link
Member

findepi commented Nov 21, 2023

can you please make sure you filled the CLA? For more information, see https://github.com/trinodb/cla.

@tbaeg
Copy link
Member Author

tbaeg commented Nov 21, 2023

can you please make sure you filled the CLA? For more information, see https://github.com/trinodb/cla.

Already signed and sent a week ago.

Copy link

cla-bot bot commented Nov 22, 2023

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@findepi
Copy link
Member

findepi commented Nov 22, 2023

can you please make sure you filled the CLA? For more information, see https://github.com/trinodb/cla.

Already signed and sent a week ago.

Thanks!

Let's wait until it's processed by @martint .

@findepi
Copy link
Member

findepi commented Nov 22, 2023

#19849 fixed an bug in Delta and Iceberg, but it had to introduce new implementations of the interfaces being changed here. I guess the implementation may require an update in this PR, since we're changing interface signatures. @tbaeg Can you please rebase?

Copy link

cla-bot bot commented Nov 22, 2023

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@tbaeg
Copy link
Member Author

tbaeg commented Nov 22, 2023

#19849 fixed an bug in Delta and Iceberg, but it had to introduce new implementations of the interfaces being changed here. I guess the implementation may require an update in this PR, since we're changing interface signatures. @tbaeg Can you please rebase?

Rebased and also added ClassLoaderSafeTableFunctionDataProcessor to be in line with the commit mentioned above. There are cases I had my own implementation so I think it makes sense to include. Let me know if you'd like a separate PR for this.

@tbaeg
Copy link
Member Author

tbaeg commented Nov 22, 2023

can you please make sure you filled the CLA? For more information, see https://github.com/trinodb/cla.

Already signed and sent a week ago.

Thanks!

Let's wait until it's processed by @martint .

CLA processed. Thanks @martint!

@findepi
Copy link
Member

findepi commented Nov 23, 2023

@cla-bot check

@cla-bot cla-bot bot added the cla-signed label Nov 23, 2023
Copy link

cla-bot bot commented Nov 23, 2023

The cla-bot has been summoned, and re-checked this pull request!

import java.util.List;
import java.util.Optional;

public class ClassLoaderSafeTableFunctionDataProcessor
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @homar

@findepi findepi merged commit 257c8ad into trinodb:master Nov 23, 2023
89 of 91 checks passed
@github-actions github-actions bot added this to the 434 milestone Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Update TableFunctionProcessorProvider.getDataProcessor to include ConnectorSession parameter
2 participants