Make createExclusive atomic: fix GcsTransactionLogSynchronizer atomicity with GCS native filesystem implementation #20180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
requested review from
electrum,
losipiuk,
elonazoulay,
ebyhr,
Praveen2112 and
findinpath
findepi
force-pushed
the
findepi/make-createexclusive-atomic-8dcb09
branch
from
56519b4
to
b956dfd
Compare
losipiuk
reviewed
Dec 20, 2023
lib/trino-filesystem/src/main/java/io/trino/filesystem/tracing/TracingOutputFile.java
Outdated
Show resolved
Hide resolved
findepi
force-pushed
the
findepi/make-createexclusive-atomic-8dcb09
branch
2 times, most recently
from
42075fc
to
220dc37
Compare
findepi
force-pushed
the
findepi/make-createexclusive-atomic-8dcb09
branch
from
220dc37
to
a6e20b0
Compare
findinpath
reviewed
Dec 20, 2023
| /** | ||
| * Specifies whether implementation supports {@link TrinoOutputFile#create()} is exclusive. | ||
| */ | ||
| protected boolean isCreateExclusive() |
There was a problem hiding this comment.
these two methods are pretty close in naming which can be rather misleading.
There was a problem hiding this comment.
that's why they got a javadoc. do you want to suggest better names?
When defining test profiles, we don't use properties.
findepi
force-pushed
the
findepi/make-createexclusive-atomic-8dcb09
branch
from
315917c
to
6297459
Compare
losipiuk
reviewed
Dec 21, 2023
| @@ -63,11 +71,22 @@ public abstract class AbstractTestTrinoFileSystem | |||
|
|
|||
| protected abstract void verifyFileSystemIsEmpty(); | |||
|
|
|||
| protected boolean supportsCreateExclusive() | |||
| /** | |||
| * Specifies whether implementation supports {@link TrinoOutputFile#create()} is exclusive. | |||
losipiuk
approved these changes
Dec 21, 2023
`GcsTransactionLogSynchronizer` requires that the new transaction log file is created exclusively and atomically. Otherwise concurrent readers of a table may see a file partially written (or not written yet, just empty) and fail. This commit: - fixes the GCS native filesystem implementation so that it's atomic - changes the method signature to indicate atomic creation and remove default not atomic implementation. - makes it clear in-memory buffering occurs (previously it was implicitly done in `HdfsOutputFile` which could be considered surprising) - in `AbstractTestTrinoFileSystem` decouples "is create() exclusive" and "supports createExclusive" behaviors. For example local filesystem has the former, GCS filesystem has both and S3 filesystem has none.
losipiuk
force-pushed
the
findepi/make-createexclusive-atomic-8dcb09
branch
from
6297459
to
b23725c
Compare
findepi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GcsTransactionLogSynchronizerrequires that the new transaction log file is created exclusively and atomically. Otherwise concurrent readers of a table may see a file partially written (or not written yet, just empty) and fail. This commit:HdfsOutputFilewhich could be considered surprising)Fixes #20168
Required by #19991