-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Iceberg: Add support for creating and dropping tables using Iceberg object store #20555
base: master
Are you sure you want to change the base?
Conversation
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
Re-created from #20516 |
cda8e04
to
4f83e8a
Compare
This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua |
Any thoughts @amogh-jahagirdar |
This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua |
Closing this pull request, as it has been stale for six weeks. Feel free to re-open at any time. |
I added the stale-ignore label so the PR stays open. Please rebase as a next step. |
3e6dc4b
to
6ed669a
Compare
6ed669a
to
a7454d1
Compare
Description
Currently, Trino is only able to write to and read from tables that use Iceberg's
ObjectStorageLocationProvider
, but is unable to create or drop tables using the location provider. This PR adds in session and table properties to use during table creation and removes an old check blocking Trino from dropping tables that use the object storage.Additional context and related issues
This PR maintains compatibility with Spark by using the table properties
write.object-storage.enabled
andwrite.data.path
, which had previously been set up to allow Trino to write to Iceberg tables using theObjectStorageLocationProvider
in #8573Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text: