Migrate Alluxio cache tests to tracing #20557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wendigo
force-pushed
the
serafin/alluxio-tracing
branch
5 times, most recently
from
52b6d88
to
49f4c14
Compare
|
I'll extract some smaller changes in that PR. But seems to be passing tests |
wendigo
force-pushed
the
serafin/alluxio-tracing
branch
4 times, most recently
from
eddc6ab
to
891e5ba
Compare
jkylling
reviewed
Feb 5, 2024
...trino-filesystem-cache-alluxio/src/main/java/io/trino/filesystem/alluxio/AlluxioTracing.java
Show resolved
Hide resolved
...-filesystem-cache-alluxio/src/main/java/io/trino/filesystem/alluxio/TracingCacheManager.java
Outdated
Show resolved
Hide resolved
...-filesystem-cache-alluxio/src/main/java/io/trino/filesystem/alluxio/TracingCacheManager.java
Show resolved
Hide resolved
...-filesystem-cache-alluxio/src/main/java/io/trino/filesystem/alluxio/TracingCacheManager.java
Show resolved
Hide resolved
...-filesystem-cache-alluxio/src/main/java/io/trino/filesystem/alluxio/TracingCacheManager.java
Outdated
Show resolved
Hide resolved
...tem-cache-alluxio/src/main/java/io/trino/filesystem/alluxio/AlluxioConfigurationFactory.java
Show resolved
Hide resolved
...io/src/test/java/io/trino/filesystem/alluxio/TestAlluxioCacheFileSystemAccessOperations.java
Outdated
Show resolved
Hide resolved
testing/trino-testing/src/main/java/io/trino/testing/TestingTelemetry.java
Show resolved
Hide resolved
wendigo
force-pushed
the
serafin/alluxio-tracing
branch
from
891e5ba
to
8639d46
Compare
wendigo
changed the title
wendigo
force-pushed
the
serafin/alluxio-tracing
branch
from
8639d46
to
a5a3f60
Compare
wendigo
force-pushed
the
serafin/alluxio-tracing
branch
from
a5a3f60
to
aaf9933
Compare
raunaqmorarka
approved these changes
Feb 5, 2024
| } | ||
|
|
||
| private int doExternalRead(long readPosition, byte[] buffer, int offset, int length) | ||
| private int doExternalRead0(long readPosition, byte[] buffer, int offset, int length) |
jkylling
approved these changes
Feb 5, 2024
lib/trino-filesystem/src/main/java/io/trino/filesystem/cache/CacheSystemAttributes.java
Outdated
Show resolved
Hide resolved
wendigo
force-pushed
the
serafin/alluxio-tracing
branch
from
aaf9933
to
e947463
Compare
TestingAlluxioCacheStats will be removed in further commit
Rewrite tests to assert on spans, rather than TrackingFileSystem
wendigo
force-pushed
the
serafin/alluxio-tracing
branch
from
e947463
to
bf36faf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #20550