Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove TrackingFileSystemFactory usage #20610

Merged
merged 7 commits into from
Feb 8, 2024
Merged

Remove TrackingFileSystemFactory usage #20610

merged 7 commits into from
Feb 8, 2024

Conversation

wendigo
Copy link
Contributor

@wendigo wendigo commented Feb 7, 2024

No release notes needed

@cla-bot cla-bot bot added the cla-signed label Feb 7, 2024
@github-actions github-actions bot added the delta-lake Delta Lake connector label Feb 7, 2024
@wendigo
Copy link
Contributor Author

wendigo commented Feb 7, 2024

A number of FS operations is the same. The only difference is the distinction between InputFile.newFile and InputFile.newStream

@wendigo
Copy link
Contributor Author

wendigo commented Feb 7, 2024 •
edited

For TestTransactionLogAccess there is a difference in the counts. Needs some investigation I guess

Fixed

@findepi findepi requested a review from ebyhr February 7, 2024 09:11
@github-actions github-actions bot added tests:hive iceberg Iceberg connector labels Feb 7, 2024
@wendigo
Copy link
Contributor Author

wendigo commented Feb 7, 2024

I've dropped TrackingFileSystemFactory altogether

@wendigo wendigo changed the title Use tracing for fs assertions in TestDeltaLakeFileOperations Remove TrackingFileSystemFactory usage Feb 7, 2024
@wendigo wendigo merged commit 08545a1 into master Feb 8, 2024
86 of 101 checks passed
@wendigo wendigo deleted the serafin/delta-lake-tracing branch February 8, 2024 12:27
@github-actions github-actions bot added this to the 439 milestone Feb 8, 2024
@wendigo wendigo mentioned this pull request Feb 8, 2024
Open
@mosabua mosabua assigned wendigo and unassigned wendigo Feb 9, 2024
@colebow colebow mentioned this pull request Feb 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@electrum electrum electrum approved these changes

@findepi findepi Awaiting requested review from findepi

@findinpath findinpath Awaiting requested review from findinpath

@ebyhr ebyhr Awaiting requested review from ebyhr

@raunaqmorarka raunaqmorarka Awaiting requested review from raunaqmorarka

Assignees
No one assigned
Labels
cla-signed delta-lake Delta Lake connector iceberg Iceberg connector
Milestone
439
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wendigo @electrum