Start Docker from Java for server RPM tests #2064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
approved these changes
Nov 19, 2019
presto-server-rpm/src/test/java/io/prestosql/server/rpm/ServerIT.java
Outdated
Show resolved
Hide resolved
presto-server-rpm/src/test/java/io/prestosql/server/rpm/ServerIT.java
Outdated
Show resolved
Hide resolved
presto-server-rpm/src/test/java/io/prestosql/server/rpm/ServerIT.java
Outdated
Show resolved
Hide resolved
| // install RPM | ||
| "rpm -i /target/" + rpm + "\n" + | ||
| // create Hive catalog file | ||
| "mkdir /etc/presto/catalog\n" + |
There was a problem hiding this comment.
/etc/presto/catalog should be part of RPM
There was a problem hiding this comment.
It's not today, and I don't see anything which should be creating it. Perhaps we should do so in postinstall?
| "hive.metastore.uri=thrift://localhost:9083\n" + | ||
| "EOT\n" + | ||
| // start server | ||
| "/etc/init.d/presto start\n" + |
There was a problem hiding this comment.
Looks like our image does not include that command
presto-server-rpm/src/test/java/io/prestosql/server/rpm/ServerIT.java
Outdated
Show resolved
Hide resolved
| @@ -55,6 +55,8 @@ | |||
| <dep.tempto.version>166</dep.tempto.version> | |||
| <dep.testng.version>6.10</dep.testng.version> | |||
| <dep.assertj-core.version>3.8.0</dep.assertj-core.version> | |||
| <!-- TODO: remove after updating to Airbase 94 --> | |||
| <dep.slf4j.version>1.7.28</dep.slf4j.version> | |||
There was a problem hiding this comment.
how this relates to test change?
There was a problem hiding this comment.
These version updates are needed to satisfy RequireUpperBoundDeps due to testcontainers using newer versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.