Support embedded alluxio cache in hive #20658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
docs
tests:hive
delta-lake
raunaqmorarka
force-pushed
the
hive-cache
branch
2 times, most recently
from
d4fbec3
to
8398a20
Compare
jkylling
approved these changes
Feb 12, 2024
| @@ -305,7 +311,7 @@ else if (maxSplitBytes * 2 >= remainingBlockBytes) { | |||
| internalSplit.getFileModifiedTime(), | |||
| internalSplit.getSchema(), | |||
| internalSplit.getPartitionKeys(), | |||
| block.getAddresses(), | |||
| cachingHostAddressProvider.getHosts(internalSplit.getPath(), block.getAddresses()), | |||
There was a problem hiding this comment.
Do we need to extend the interface with defaultAddresses? We could also do
block.getAddresses().isEmpty() ? cachingHostAddressProvider.getHosts(internalSplit.getPath()) : block.getAddresses(),
There was a problem hiding this comment.
Block addresses are populated when the filesystem is HDFS. When caching is used with HDFS, we still want caching to drive split scheduling decision rather than HDFS block locality.
...em-cache-alluxio/src/main/java/io/trino/filesystem/alluxio/AlluxioFileSystemCacheModule.java
Outdated
Show resolved
Hide resolved
raunaqmorarka
force-pushed
the
hive-cache
branch
2 times, most recently
from
b269320
to
ee8145b
Compare
wendigo
approved these changes
Feb 12, 2024
...no-filesystem/src/main/java/io/trino/filesystem/cache/DefaultCachingHostAddressProvider.java
Show resolved
Hide resolved
lib/trino-filesystem/src/main/java/io/trino/filesystem/cache/CachingHostAddressProvider.java
Show resolved
Hide resolved
plugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakeSplitManager.java
Show resolved
Hide resolved
Allows connector to use it's own host addresses for split scheduling when caching is not enabled
raunaqmorarka
force-pushed
the
hive-cache
branch
from
ee8145b
to
9c476f7
Compare
|
@raunaqmorarka merge it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support embedded alluxio cache in hive
Additional context and related issues
Part of #20550
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text: